Checkstyle Results
The following document contains the results of Checkstyle 10.20.0 with sun_checks.xml ruleset.
Summary
| Files |  Info |
 Warnings |
 Errors |
|---|---|---|---|
| 145 | 0 | 0 | 2924 |
Files
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | AvoidNestedBlocks | 20 | Error |
| EmptyBlock | 2 | Error | |
| NeedBraces | 12 | Error | |
| coding | HiddenField | 77 | Error |
| InnerAssignment | 3 | Error | |
| MagicNumber | 423 | Error | |
| MissingSwitchDefault | 3 | Error | |
| MultipleVariableDeclarations | 2 | Error | |
| SimplifyBooleanExpression | 1 | Error | |
| design | DesignForExtension | 217 | Error |
| FinalClass | 19 | Error | |
| HideUtilityClassConstructor | 16 | Error | |
| VisibilityModifier | 85 | Error | |
| imports | AvoidStarImport | 112 | Error |
UnusedImports
|
6 | Error | |
| javadoc | JavadocMethod | 44 | Error |
| JavadocPackage | 41 | Error | |
| JavadocStyle | 63 | Error | |
| JavadocType | 1 | Error | |
| JavadocVariable | 613 | Error | |
| MissingJavadocMethod | 269 | Error | |
| misc | ArrayTypeStyle | 1 | Error |
| FinalParameters | 614 | Error | |
| NewlineAtEndOfFile | 11 | Error | |
| modifier | ModifierOrder | 5 | Error |
| RedundantModifier | 22 | Error | |
| naming | ConstantName | 25 | Error |
| LocalVariableName | 6 | Error | |
| MemberName | 1 | Error | |
| ParameterName | 2 | Error | |
| regexp | RegexpSingleline
|
65 | Error |
| sizes | MethodLength | 1 | Error |
| whitespace | FileTabCharacter | 6 | Error |
| NoWhitespaceAfter | 8 | Error | |
| NoWhitespaceBefore | 2 | Error | |
| OperatorWrap | 7 | Error | |
| WhitespaceAfter | 47 | Error | |
| WhitespaceAround | 72 | Error |
Details
apktoolbox.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
apktoolbox_zh.properties
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
edu/jiangxin/apktoolbox/Version.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 3 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 4 |
edu/jiangxin/apktoolbox/android/dumpsys/alarm/Alarm.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
design | FinalClass | Class Alarm should be declared as final. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Error |
misc | FinalParameters | Parameter parentBatch should be final. | 19 |
| Error |
coding | HiddenField | 'parentBatch' hides a field. | 19 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
| Error |
misc | FinalParameters | Parameter stringDefinition should be final. | 23 |
| Error |
misc | FinalParameters | Parameter stringDefinition should be final. | 27 |
| Error |
coding | MissingSwitchDefault | switch without "default" clause. | 40 |
| Error |
coding | MagicNumber | '3' is a magic number. | 50 |
| Error |
coding | MagicNumber | '5' is a magic number. | 55 |
| Error |
coding | MagicNumber | '4' is a magic number. | 56 |
| Error |
coding | MagicNumber | '4' is a magic number. | 57 |
| Error |
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 57 |
| Error |
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 57 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 80 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 84 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 88 |
edu/jiangxin/apktoolbox/android/dumpsys/alarm/AlarmBatch.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | FinalClass | Class AlarmBatch should be declared as final. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
design | VisibilityModifier | Variable 'flags' must be private and have accessor methods. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Error |
misc | FinalParameters | Parameter alarm should be final. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
misc | FinalParameters | Parameter batchDefinition should be final. | 21 |
| Error |
coding | MagicNumber | '4' is a magic number. | 23 |
| Error |
misc | FinalParameters | Parameter components should be final. | 29 |
| Error |
coding | MagicNumber | '5' is a magic number. | 33 |
| Error |
coding | MagicNumber | '4' is a magic number. | 34 |
| Error |
coding | MagicNumber | '3' is a magic number. | 39 |
| Error |
misc | FinalParameters | Parameter expression should be final. | 42 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 73 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 77 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 81 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 85 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 89 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
edu/jiangxin/apktoolbox/android/dumpsys/alarm/AlarmTreeTableDataModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
modifier | ModifierOrder | 'protected' modifier out of order with the JLS suggestions. | 7 |
| Error |
design | VisibilityModifier | Variable 'columnNames' must be private and have accessor methods. | 7 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
modifier | ModifierOrder | 'protected' modifier out of order with the JLS suggestions. | 9 |
| Error |
design | VisibilityModifier | Variable 'columnTypes' must be private and have accessor methods. | 9 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 9 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Error |
misc | FinalParameters | Parameter rootNode should be final. | 11 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'getChild' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'getChild' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Error |
misc | FinalParameters | Parameter parent should be final. | 16 |
| Error |
misc | FinalParameters | Parameter index should be final. | 16 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'getChildCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'getChildCount' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
misc | FinalParameters | Parameter parent should be final. | 21 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'getColumnCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'getColumnCount' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'getColumnName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'getColumnName' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
| Error |
misc | FinalParameters | Parameter column should be final. | 31 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'getColumnClass' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'getColumnClass' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
misc | FinalParameters | Parameter column should be final. | 36 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'getValueAt' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'getValueAt' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
misc | FinalParameters | Parameter node should be final. | 40 |
| Error |
misc | FinalParameters | Parameter column should be final. | 40 |
| Error |
coding | MagicNumber | '3' is a magic number. | 48 |
| Error |
coding | MagicNumber | '4' is a magic number. | 50 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataModel' looks like designed for extension (can be subclassed), but the method 'isCellEditable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataModel' final or making the method 'isCellEditable' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
| Error |
misc | FinalParameters | Parameter node should be final. | 58 |
| Error |
misc | FinalParameters | Parameter column should be final. | 58 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
| Error |
misc | FinalParameters | Parameter aValue should be final. | 62 |
| Error |
misc | FinalParameters | Parameter node should be final. | 62 |
| Error |
misc | FinalParameters | Parameter column should be final. | 62 |
edu/jiangxin/apktoolbox/android/dumpsys/alarm/AlarmTreeTableDataNode.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
misc | FinalParameters | Parameter objectId should be final. | 15 |
| Error |
coding | HiddenField | 'objectId' hides a field. | 15 |
| Error |
misc | FinalParameters | Parameter appPackage should be final. | 15 |
| Error |
coding | HiddenField | 'appPackage' hides a field. | 15 |
| Error |
misc | FinalParameters | Parameter alarmType should be final. | 15 |
| Error |
coding | HiddenField | 'alarmType' hides a field. | 15 |
| Error |
misc | FinalParameters | Parameter when should be final. | 15 |
| Error |
coding | HiddenField | 'when' hides a field. | 15 |
| Error |
misc | FinalParameters | Parameter fireDateTime should be final. | 15 |
| Error |
coding | HiddenField | 'fireDateTime' hides a field. | 15 |
| Error |
misc | FinalParameters | Parameter children should be final. | 15 |
| Error |
coding | HiddenField | 'children' hides a field. | 15 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'getObjectId' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'getObjectId' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'getAppPackage' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'getAppPackage' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'getAlarmType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'getAlarmType' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'getWhen' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'getWhen' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'getFireDateTime' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'getFireDateTime' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'getChildren' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'getChildren' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
| Error |
design | DesignForExtension | Class 'AlarmTreeTableDataNode' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlarmTreeTableDataNode' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
edu/jiangxin/apktoolbox/android/dumpsys/alarm/DumpsysAlarmPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 14 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
| Error |
design | DesignForExtension | Class 'DumpsysAlarmPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DumpsysAlarmPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
| Error |
coding | MagicNumber | '4' is a magic number. | 251 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 253 |
| Error |
coding | MagicNumber | '3600' is a magic number. | 254 |
| Error |
coding | MagicNumber | '3600' is a magic number. | 255 |
| Error |
coding | MagicNumber | '60' is a magic number. | 255 |
| Error |
coding | MagicNumber | '60' is a magic number. | 256 |
| Error |
misc | FinalParameters | Parameter listBatches should be final. | 305 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 312 |
| Error |
misc | FinalParameters | Parameter e should be final. | 324 |
| Error |
misc | FinalParameters | Parameter e should be final. | 332 |
edu/jiangxin/apktoolbox/android/dumpsys/alarm/SharedData.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | FinalClass | Class SharedData should be declared as final. | 3 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 4 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Error |
misc | FinalParameters | Parameter timestamp should be final. | 24 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
| Error |
misc | FinalParameters | Parameter uptimeMs should be final. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
misc | FinalParameters | Parameter dateTime should be final. | 40 |
edu/jiangxin/apktoolbox/android/i18n/I18nAddPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 2 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 19 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 20 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 21 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 33 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
naming | ConstantName | Name 'replace' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 55 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
| Error |
design | DesignForExtension | Class 'I18nAddPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'I18nAddPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 119 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 134 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 150 |
| Error |
misc | FinalParameters | Parameter sourceBaseStr should be final. | 162 |
| Error |
misc | FinalParameters | Parameter targetBaseStr should be final. | 162 |
| Error |
misc | FinalParameters | Parameter itemName should be final. | 162 |
| Error |
misc | FinalParameters | Parameter pathname should be final. | 173 |
| Error |
misc | FinalParameters | Parameter sourceFile should be final. | 219 |
| Error |
misc | FinalParameters | Parameter itemName should be final. | 219 |
| Error |
misc | FinalParameters | Parameter targetFile should be final. | 248 |
| Error |
misc | FinalParameters | Parameter sourceElement should be final. | 248 |
| Error |
misc | FinalParameters | Parameter itemName should be final. | 248 |
| Error |
misc | FinalParameters | Parameter file should be final. | 297 |
| Error |
misc | FinalParameters | Parameter file should be final. | 305 |
edu/jiangxin/apktoolbox/android/i18n/I18nFindLongestPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 13 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
| Error |
design | DesignForExtension | Class 'I18nFindLongestPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'I18nFindLongestPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
| Error |
misc | FinalParameters | Parameter e should be final. | 63 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 102 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 117 |
| Error |
misc | FinalParameters | Parameter file should be final. | 129 |
| Error |
misc | FinalParameters | Parameter sourceBaseStr should be final. | 142 |
| Error |
misc | FinalParameters | Parameter itemName should be final. | 142 |
| Error |
misc | FinalParameters | Parameter pathname should be final. | 145 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 186 |
| Error |
design | VisibilityModifier | Variable 'path' must be private and have accessor methods. | 186 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 187 |
| Error |
design | VisibilityModifier | Variable 'text' must be private and have accessor methods. | 187 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 188 |
| Error |
design | VisibilityModifier | Variable 'length' must be private and have accessor methods. | 188 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 190 |
| Error |
misc | FinalParameters | Parameter path should be final. | 190 |
| Error |
coding | HiddenField | 'path' hides a field. | 190 |
| Error |
misc | FinalParameters | Parameter text should be final. | 190 |
| Error |
coding | HiddenField | 'text' hides a field. | 190 |
| Error |
misc | FinalParameters | Parameter length should be final. | 190 |
| Error |
coding | HiddenField | 'length' hides a field. | 190 |
edu/jiangxin/apktoolbox/android/i18n/I18nRemovePanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
design | VisibilityModifier | Variable 'infos' must be private and have accessor methods. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 46 |
| Error |
design | DesignForExtension | Class 'I18nRemovePanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'I18nRemovePanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
| Error |
misc | FinalParameters | Parameter e should be final. | 70 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 94 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 109 |
| Error |
misc | FinalParameters | Parameter sourceBaseStr should be final. | 121 |
| Error |
misc | FinalParameters | Parameter itemName should be final. | 121 |
| Error |
misc | FinalParameters | Parameter pathname should be final. | 124 |
edu/jiangxin/apktoolbox/android/monkey/MonkeyPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 11 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 44 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 49 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 54 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 59 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
| Error |
design | VisibilityModifier | Variable 'threadTimeType' must be private and have accessor methods. | 64 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
| Error |
design | VisibilityModifier | Variable 'monkeyProcess' must be private and have accessor methods. | 65 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
| Error |
design | VisibilityModifier | Variable 'comboBoxDevices' must be private and have accessor methods. | 67 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
| Error |
design | VisibilityModifier | Variable 'refreshButton' must be private and have accessor methods. | 68 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
| Error |
design | VisibilityModifier | Variable 'logPathButton' must be private and have accessor methods. | 70 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 71 |
| Error |
design | VisibilityModifier | Variable 'executeButton' must be private and have accessor methods. | 71 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 73 |
| Error |
design | VisibilityModifier | Variable 'resetButton' must be private and have accessor methods. | 73 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 74 |
| Error |
design | VisibilityModifier | Variable 'interruptButton' must be private and have accessor methods. | 74 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 76 |
| Error |
design | VisibilityModifier | Variable 'labelHour' must be private and have accessor methods. | 76 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
| Error |
design | VisibilityModifier | Variable 'labelMinute' must be private and have accessor methods. | 77 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 78 |
| Error |
design | VisibilityModifier | Variable 'labelSecond' must be private and have accessor methods. | 78 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 79 |
| Error |
design | VisibilityModifier | Variable 'textMillisecond' must be private and have accessor methods. | 79 |
| Error |
coding | MagicNumber | '30' is a magic number. | 79 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 80 |
| Error |
design | VisibilityModifier | Variable 'textTime' must be private and have accessor methods. | 80 |
| Error |
coding | MagicNumber | '30' is a magic number. | 80 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 81 |
| Error |
design | VisibilityModifier | Variable 'textLogPath' must be private and have accessor methods. | 81 |
| Error |
coding | MagicNumber | '90' is a magic number. | 81 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 83 |
| Error |
design | VisibilityModifier | Variable 'comboBoxProgram' must be private and have accessor methods. | 83 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 84 |
| Error |
design | VisibilityModifier | Variable 'comboBoxTime' must be private and have accessor methods. | 84 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 86 |
| Error |
design | VisibilityModifier | Variable 'checkBoxDbgNoEvents' must be private and have accessor methods. | 89 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 91 |
| Error |
design | VisibilityModifier | Variable 'checkBoxHprof' must be private and have accessor methods. | 94 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 96 |
| Error |
design | VisibilityModifier | Variable 'checkBoxCrashes' must be private and have accessor methods. | 99 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 101 |
| Error |
design | VisibilityModifier | Variable 'checkBoxTimeouts' must be private and have accessor methods. | 104 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 106 |
| Error |
design | VisibilityModifier | Variable 'checkBoxNativeCrashes' must be private and have accessor methods. | 109 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 111 |
| Error |
design | VisibilityModifier | Variable 'checkBoxExceptions' must be private and have accessor methods. | 114 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 116 |
| Error |
design | VisibilityModifier | Variable 'checkBoxKill' must be private and have accessor methods. | 119 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 121 |
| Error |
design | VisibilityModifier | Variable 'checkBoxWaitDbg' must be private and have accessor methods. | 124 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 126 |
| Error |
design | VisibilityModifier | Variable 'group' must be private and have accessor methods. | 126 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 128 |
| Error |
design | VisibilityModifier | Variable 'radioButton0' must be private and have accessor methods. | 131 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 133 |
| Error |
design | VisibilityModifier | Variable 'radioButton1' must be private and have accessor methods. | 136 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 138 |
| Error |
design | VisibilityModifier | Variable 'radioButton2' must be private and have accessor methods. | 141 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 143 |
| Error |
design | VisibilityModifier | Variable 'list' must be private and have accessor methods. | 143 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 144 |
| Error |
design | VisibilityModifier | Variable 'flag' must be private and have accessor methods. | 144 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 145 |
| Error |
design | VisibilityModifier | Variable 'monkeyCmd' must be private and have accessor methods. | 145 |
| Error |
design | DesignForExtension | Class 'MonkeyPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MonkeyPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 147 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 193 |
| Error |
coding | MagicNumber | '60' is a magic number. | 195 |
| Error |
coding | MagicNumber | '25' is a magic number. | 195 |
| Error |
coding | MagicNumber | '240' is a magic number. | 196 |
| Error |
coding | MagicNumber | '25' is a magic number. | 196 |
| Error |
coding | MagicNumber | '60' is a magic number. | 197 |
| Error |
coding | MagicNumber | '25' is a magic number. | 197 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 212 |
| Error |
coding | MagicNumber | '60' is a magic number. | 214 |
| Error |
coding | MagicNumber | '25' is a magic number. | 214 |
| Error |
coding | MagicNumber | '240' is a magic number. | 215 |
| Error |
coding | MagicNumber | '25' is a magic number. | 215 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 233 |
| Error |
coding | MagicNumber | '60' is a magic number. | 235 |
| Error |
coding | MagicNumber | '25' is a magic number. | 235 |
| Error |
coding | MagicNumber | '100' is a magic number. | 236 |
| Error |
coding | MagicNumber | '25' is a magic number. | 236 |
| Error |
coding | MagicNumber | '100' is a magic number. | 237 |
| Error |
coding | MagicNumber | '25' is a magic number. | 237 |
| Error |
coding | MagicNumber | '110' is a magic number. | 238 |
| Error |
coding | MagicNumber | '25' is a magic number. | 238 |
| Error |
coding | MagicNumber | '180' is a magic number. | 239 |
| Error |
coding | MagicNumber | '25' is a magic number. | 239 |
| Error |
coding | MagicNumber | '180' is a magic number. | 240 |
| Error |
coding | MagicNumber | '25' is a magic number. | 240 |
| Error |
coding | MagicNumber | '280' is a magic number. | 241 |
| Error |
coding | MagicNumber | '25' is a magic number. | 241 |
| Error |
coding | MagicNumber | '280' is a magic number. | 242 |
| Error |
coding | MagicNumber | '25' is a magic number. | 242 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 254 |
| Error |
coding | MagicNumber | '60' is a magic number. | 256 |
| Error |
coding | MagicNumber | '25' is a magic number. | 256 |
| Error |
coding | MagicNumber | '150' is a magic number. | 257 |
| Error |
coding | MagicNumber | '25' is a magic number. | 257 |
| Error |
coding | MagicNumber | '7' is a magic number. | 258 |
| Error |
coding | MagicNumber | '40' is a magic number. | 261 |
| Error |
coding | MagicNumber | '25' is a magic number. | 261 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 268 |
| Error |
coding | MagicNumber | '60' is a magic number. | 270 |
| Error |
coding | MagicNumber | '25' is a magic number. | 270 |
| Error |
coding | MagicNumber | '150' is a magic number. | 271 |
| Error |
coding | MagicNumber | '25' is a magic number. | 271 |
| Error |
coding | MagicNumber | '7' is a magic number. | 272 |
| Error |
coding | MagicNumber | '60' is a magic number. | 274 |
| Error |
coding | MagicNumber | '25' is a magic number. | 274 |
| Error |
coding | MagicNumber | '50' is a magic number. | 279 |
| Error |
coding | MagicNumber | '25' is a magic number. | 279 |
| Error |
coding | MagicNumber | '50' is a magic number. | 280 |
| Error |
coding | MagicNumber | '25' is a magic number. | 280 |
| Error |
coding | MagicNumber | '50' is a magic number. | 281 |
| Error |
coding | MagicNumber | '25' is a magic number. | 281 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 292 |
| Error |
coding | MagicNumber | '60' is a magic number. | 294 |
| Error |
coding | MagicNumber | '25' is a magic number. | 294 |
| Error |
coding | MagicNumber | '80' is a magic number. | 300 |
| Error |
coding | MagicNumber | '25' is a magic number. | 300 |
| Error |
coding | MagicNumber | '80' is a magic number. | 301 |
| Error |
coding | MagicNumber | '25' is a magic number. | 301 |
| Error |
coding | MagicNumber | '80' is a magic number. | 302 |
| Error |
coding | MagicNumber | '25' is a magic number. | 302 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 310 |
| Error |
coding | MagicNumber | '100' is a magic number. | 311 |
| Error |
coding | MagicNumber | '25' is a magic number. | 311 |
| Error |
coding | MagicNumber | '60' is a magic number. | 312 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 331 |
| Error |
coding | MagicNumber | '100' is a magic number. | 332 |
| Error |
coding | MagicNumber | '25' is a magic number. | 332 |
| Error |
coding | MagicNumber | '100' is a magic number. | 333 |
| Error |
coding | MagicNumber | '25' is a magic number. | 333 |
| Error |
coding | MagicNumber | '100' is a magic number. | 334 |
| Error |
coding | MagicNumber | '25' is a magic number. | 334 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 361 |
| Error |
coding | MagicNumber | '3600' is a magic number. | 389 |
| Error |
coding | MagicNumber | '60' is a magic number. | 391 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 475 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 482 |
| Error |
coding | MagicNumber | '7' is a magic number. | 525 |
| Error |
misc | FinalParameters | Parameter device should be final. | 541 |
| Error |
misc | FinalParameters | Parameter cmd should be final. | 573 |
| Error |
misc | FinalParameters | Parameter keyValue should be final. | 573 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 613 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 615 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 618 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 620 |
| Error |
misc | FinalParameters | Parameter times should be final. | 620 |
| Error |
coding | HiddenField | 'times' hides a field. | 620 |
| Error |
coding | MagicNumber | '3600' is a magic number. | 643 |
| Error |
coding | MagicNumber | '3600' is a magic number. | 644 |
| Error |
coding | MagicNumber | '60' is a magic number. | 644 |
| Error |
coding | MagicNumber | '3600' is a magic number. | 645 |
| Error |
coding | MagicNumber | '60' is a magic number. | 645 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 650 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 676 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 678 |
| Error |
misc | FinalParameters | Parameter time should be final. | 682 |
| Error |
misc | FinalParameters | Parameter keyValue should be final. | 682 |
| Error |
coding | MagicNumber | '120' is a magic number. | 683 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 686 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 703 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 716 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 718 |
| Error |
misc | FinalParameters | Parameter time should be final. | 722 |
| Error |
misc | FinalParameters | Parameter keyValue should be final. | 722 |
| Error |
coding | MagicNumber | '120' is a magic number. | 723 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 726 |
| Error |
misc | FinalParameters | Parameter msg3 should be final. | 748 |
| Error |
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 749 |
| Error |
coding | MagicNumber | '320' is a magic number. | 750 |
| Error |
coding | MagicNumber | '180' is a magic number. | 750 |
| Error |
coding | MagicNumber | '70' is a magic number. | 754 |
| Error |
coding | MagicNumber | '200' is a magic number. | 754 |
| Error |
coding | MagicNumber | '100' is a magic number. | 754 |
| Error |
coding | MagicNumber | '97' is a magic number. | 756 |
| Error |
coding | MagicNumber | '80' is a magic number. | 756 |
| Error |
coding | MagicNumber | '100' is a magic number. | 756 |
| Error |
coding | MagicNumber | '25' is a magic number. | 756 |
| Error |
coding | MagicNumber | '320' is a magic number. | 761 |
| Error |
coding | MagicNumber | '180' is a magic number. | 762 |
edu/jiangxin/apktoolbox/android/screenshot/ScreenShotPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
design | DesignForExtension | Class 'ScreenShotPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ScreenShotPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Error |
misc | FinalParameters | Parameter e should be final. | 112 |
| Error |
misc | FinalParameters | Parameter e should be final. | 133 |
| Error |
misc | FinalParameters | Parameter e should be final. | 140 |
| Error |
misc | FinalParameters | Parameter comp should be final. | 181 |
| Error |
misc | FinalParameters | Parameter t should be final. | 181 |
| Error |
misc | FinalParameters | Parameter jComponent should be final. | 195 |
| Error |
misc | FinalParameters | Parameter dataFlavors should be final. | 195 |
| Error |
misc | FinalParameters | Parameter frame should be final. | 205 |
| Error |
misc | FinalParameters | Parameter flavor should be final. | 208 |
| Error |
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 217 |
| Error |
misc | FinalParameters | Parameter flavor should be final. | 221 |
edu/jiangxin/apktoolbox/convert/base/BaseConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.text.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
design | DesignForExtension | Class 'BaseConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BaseConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
| Error |
coding | MagicNumber | '8' is a magic number. | 48 |
| Error |
coding | MagicNumber | '10' is a magic number. | 49 |
| Error |
coding | MagicNumber | '16' is a magic number. | 50 |
| Error |
misc | FinalParameters | Parameter arg0 should be final. | 65 |
| Error |
misc | FinalParameters | Parameter e should be final. | 76 |
| Error |
misc | FinalParameters | Parameter e should be final. | 80 |
| Error |
misc | FinalParameters | Parameter e should be final. | 85 |
| Error |
misc | FinalParameters | Parameter fb should be final. | 92 |
| Error |
misc | FinalParameters | Parameter offset should be final. | 92 |
| Error |
misc | FinalParameters | Parameter string should be final. | 92 |
| Error |
misc | FinalParameters | Parameter attr should be final. | 92 |
| Error |
misc | FinalParameters | Parameter fb should be final. | 112 |
| Error |
misc | FinalParameters | Parameter offset should be final. | 112 |
| Error |
misc | FinalParameters | Parameter length should be final. | 112 |
| Error |
misc | FinalParameters | Parameter text should be final. | 112 |
| Error |
misc | FinalParameters | Parameter attrs should be final. | 112 |
| Error |
misc | FinalParameters | Parameter documentEvent should be final. | 132 |
| Error |
misc | FinalParameters | Parameter radix should be final. | 138 |
| Error |
misc | FinalParameters | Parameter str should be final. | 167 |
| Error |
misc | FinalParameters | Parameter str should be final. | 179 |
| Error |
misc | FinalParameters | Parameter str should be final. | 191 |
| Error |
misc | FinalParameters | Parameter str should be final. | 203 |
| Error |
misc | FinalParameters | Parameter radix should be final. | 216 |
| Error |
misc | FinalParameters | Parameter text should be final. | 216 |
| Error |
coding | MagicNumber | '8' is a magic number. | 221 |
| Error |
coding | MagicNumber | '10' is a magic number. | 224 |
| Error |
coding | MagicNumber | '16' is a magic number. | 227 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 237 |
| Error |
design | VisibilityModifier | Variable 'radix' must be private and have accessor methods. | 237 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 239 |
| Error |
design | VisibilityModifier | Variable 'panel' must be private and have accessor methods. | 239 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 241 |
| Error |
design | VisibilityModifier | Variable 'label' must be private and have accessor methods. | 241 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 243 |
| Error |
design | VisibilityModifier | Variable 'textField' must be private and have accessor methods. | 243 |
| Error |
misc | FinalParameters | Parameter radix should be final. | 245 |
| Error |
coding | HiddenField | 'radix' hides a field. | 245 |
| Error |
coding | MagicNumber | '50' is a magic number. | 251 |
| Error |
coding | MagicNumber | '25' is a magic number. | 251 |
| Error |
coding | MagicNumber | '8' is a magic number. | 269 |
| Error |
coding | MagicNumber | '10' is a magic number. | 272 |
| Error |
coding | MagicNumber | '16' is a magic number. | 275 |
edu/jiangxin/apktoolbox/convert/color/ColorConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
| Error |
design | DesignForExtension | Class 'ColorConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ColorConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
| Error |
design | DesignForExtension | Class 'ColorConvertPanel' looks like designed for extension (can be subclassed), but the method 'createColorBoxPanel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ColorConvertPanel' final or making the method 'createColorBoxPanel' static/final/abstract/empty, or adding allowed annotation for the method. | 94 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 94 |
| Error |
coding | MagicNumber | '255' is a magic number. | 123 |
| Error |
coding | MagicNumber | '255' is a magic number. | 128 |
| Error |
coding | MagicNumber | '255' is a magic number. | 133 |
| Error |
coding | MagicNumber | '3' is a magic number. | 153 |
| Error |
coding | MagicNumber | '360' is a magic number. | 171 |
| Error |
coding | MagicNumber | '100' is a magic number. | 176 |
| Error |
coding | MagicNumber | '100' is a magic number. | 176 |
| Error |
coding | MagicNumber | '100' is a magic number. | 182 |
| Error |
coding | MagicNumber | '100' is a magic number. | 182 |
| Error |
coding | MagicNumber | '360' is a magic number. | 210 |
| Error |
coding | MagicNumber | '100' is a magic number. | 215 |
| Error |
coding | MagicNumber | '100' is a magic number. | 215 |
| Error |
coding | MagicNumber | '50' is a magic number. | 221 |
| Error |
coding | MagicNumber | '100' is a magic number. | 221 |
| Error |
coding | MagicNumber | '100' is a magic number. | 249 |
| Error |
coding | MagicNumber | '100' is a magic number. | 249 |
| Error |
coding | MagicNumber | '100' is a magic number. | 254 |
| Error |
coding | MagicNumber | '100' is a magic number. | 254 |
| Error |
coding | MagicNumber | '100' is a magic number. | 260 |
| Error |
coding | MagicNumber | '100' is a magic number. | 260 |
| Error |
coding | MagicNumber | '100' is a magic number. | 265 |
| Error |
coding | MagicNumber | '50' is a magic number. | 297 |
| Error |
coding | MagicNumber | '100' is a magic number. | 297 |
| Error |
coding | MagicNumber | '-128' is a magic number. | 302 |
| Error |
coding | MagicNumber | '127' is a magic number. | 302 |
| Error |
coding | MagicNumber | '-128' is a magic number. | 308 |
| Error |
coding | MagicNumber | '127' is a magic number. | 308 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 365 |
| Error |
misc | FinalParameters | Parameter data should be final. | 365 |
| Error |
misc | FinalParameters | Parameter columnNames should be final. | 365 |
| Error |
misc | FinalParameters | Parameter row should be final. | 370 |
| Error |
misc | FinalParameters | Parameter column should be final. | 370 |
| Error |
design | FinalClass | Class ColorTableCellRenderer should be declared as final. | 375 |
| Error |
misc | FinalParameters | Parameter table should be final. | 377 |
| Error |
misc | FinalParameters | Parameter value should be final. | 377 |
| Error |
misc | FinalParameters | Parameter isSelected should be final. | 377 |
| Error |
misc | FinalParameters | Parameter hasFocus should be final. | 377 |
| Error |
misc | FinalParameters | Parameter row should be final. | 377 |
| Error |
misc | FinalParameters | Parameter column should be final. | 377 |
| Error |
coding | HiddenField | 'color' hides a field. | 384 |
| Error |
misc | FinalParameters | Parameter colorMode should be final. | 390 |
| Error |
coding | MagicNumber | '3' is a magic number. | 416 |
| Error |
misc | FinalParameters | Parameter e should be final. | 431 |
| Error |
misc | FinalParameters | Parameter e should be final. | 447 |
| Error |
misc | FinalParameters | Parameter e should be final. | 463 |
| Error |
misc | FinalParameters | Parameter e should be final. | 479 |
| Error |
misc | FinalParameters | Parameter e should be final. | 496 |
| Error |
misc | FinalParameters | Parameter e should be final. | 512 |
| Error |
misc | FinalParameters | Parameter e should be final. | 517 |
| Error |
misc | FinalParameters | Parameter e should be final. | 522 |
edu/jiangxin/apktoolbox/convert/color/ColorPickerPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 7 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 58 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 60 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 67 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
| Error |
coding | MagicNumber | '5' is a magic number. | 69 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 76 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 79 |
| Error |
misc | ArrayTypeStyle | Array brackets at illegal position. | 79 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 81 |
| Error |
design | VisibilityModifier | Variable 'hsbArr' must be private and have accessor methods. | 81 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 83 |
| Error |
design | DesignForExtension | Class 'ColorPickerPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ColorPickerPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 85 |
| Error |
coding | MagicNumber | '3' is a magic number. | 137 |
| Error |
coding | MagicNumber | '100' is a magic number. | 188 |
| Error |
coding | MagicNumber | '3' is a magic number. | 197 |
| Error |
coding | MagicNumber | '3' is a magic number. | 197 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 246 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 249 |
| Error |
coding | MagicNumber | '100' is a magic number. | 266 |
| Error |
coding | MagicNumber | '100' is a magic number. | 266 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 269 |
| Error |
coding | MagicNumber | '100' is a magic number. | 319 |
| Error |
coding | MagicNumber | '100' is a magic number. | 319 |
| Error |
coding | MagicNumber | '100' is a magic number. | 319 |
| Error |
design | DesignForExtension | Class 'ColorPickerPanel' looks like designed for extension (can be subclassed), but the method 'getMouseArea' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ColorPickerPanel' final or making the method 'getMouseArea' static/final/abstract/empty, or adding allowed annotation for the method. | 328 |
| Error |
coding | MagicNumber | '100' is a magic number. | 333 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 341 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'g'. | 344 |
| Error |
coding | MagicNumber | '255' is a magic number. | 372 |
| Error |
coding | MagicNumber | '255' is a magic number. | 372 |
| Error |
coding | MagicNumber | '255' is a magic number. | 372 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 379 |
| Error |
misc | FinalParameters | Parameter g2 should be final. | 384 |
| Error |
coding | MagicNumber | '3' is a magic number. | 399 |
edu/jiangxin/apktoolbox/convert/color/ColorUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 8 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 11 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Error |
misc | FinalParameters | Parameter hexColor should be final. | 12 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Error |
misc | FinalParameters | Parameter color should be final. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
misc | FinalParameters | Parameter hueI should be final. | 20 |
| Error |
misc | FinalParameters | Parameter saturationI should be final. | 20 |
| Error |
misc | FinalParameters | Parameter brightnessI should be final. | 20 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
| Error |
misc | FinalParameters | Parameter color should be final. | 27 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
| Error |
misc | FinalParameters | Parameter hueI should be final. | 34 |
| Error |
misc | FinalParameters | Parameter saturationI should be final. | 34 |
| Error |
misc | FinalParameters | Parameter lightnessI should be final. | 34 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
| Error |
misc | FinalParameters | Parameter color should be final. | 41 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
| Error |
misc | FinalParameters | Parameter cyanI should be final. | 48 |
| Error |
misc | FinalParameters | Parameter magentaI should be final. | 48 |
| Error |
misc | FinalParameters | Parameter yellowI should be final. | 48 |
| Error |
misc | FinalParameters | Parameter keyI should be final. | 48 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
| Error |
misc | FinalParameters | Parameter color should be final. | 55 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
| Error |
misc | FinalParameters | Parameter L should be final. | 62 |
| Error |
naming | ParameterName | Name 'L' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 62 |
| Error |
misc | FinalParameters | Parameter a should be final. | 62 |
| Error |
misc | FinalParameters | Parameter b should be final. | 62 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 69 |
| Error |
misc | FinalParameters | Parameter color should be final. | 69 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 76 |
| Error |
misc | FinalParameters | Parameter value should be final. | 76 |
| Error |
coding | MagicNumber | '255f' is a magic number. | 77 |
| Error |
coding | MagicNumber | '255f' is a magic number. | 78 |
| Error |
coding | MagicNumber | '255f' is a magic number. | 79 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 83 |
| Error |
misc | FinalParameters | Parameter value should be final. | 83 |
| Error |
coding | MagicNumber | '255' is a magic number. | 84 |
| Error |
coding | MagicNumber | '255' is a magic number. | 85 |
| Error |
coding | MagicNumber | '255' is a magic number. | 86 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 90 |
| Error |
misc | FinalParameters | Parameter value should be final. | 90 |
| Error |
coding | MagicNumber | '360' is a magic number. | 91 |
| Error |
coding | MagicNumber | '100' is a magic number. | 92 |
| Error |
coding | MagicNumber | '100' is a magic number. | 93 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 97 |
| Error |
misc | FinalParameters | Parameter value should be final. | 97 |
| Error |
coding | MagicNumber | '360f' is a magic number. | 98 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 99 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 100 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
| Error |
misc | FinalParameters | Parameter value should be final. | 104 |
| Error |
coding | MagicNumber | '360' is a magic number. | 105 |
| Error |
coding | MagicNumber | '100' is a magic number. | 106 |
| Error |
coding | MagicNumber | '100' is a magic number. | 107 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 111 |
| Error |
misc | FinalParameters | Parameter value should be final. | 111 |
| Error |
coding | MagicNumber | '360f' is a magic number. | 112 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 113 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 114 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 119 |
| Error |
misc | FinalParameters | Parameter value should be final. | 119 |
| Error |
coding | MagicNumber | '100' is a magic number. | 120 |
| Error |
coding | MagicNumber | '100' is a magic number. | 121 |
| Error |
coding | MagicNumber | '100' is a magic number. | 122 |
| Error |
coding | MagicNumber | '3' is a magic number. | 123 |
| Error |
coding | MagicNumber | '100' is a magic number. | 123 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 127 |
| Error |
misc | FinalParameters | Parameter value should be final. | 127 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 128 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 129 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 130 |
| Error |
coding | MagicNumber | '3' is a magic number. | 131 |
| Error |
coding | MagicNumber | '100f' is a magic number. | 131 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 136 |
| Error |
misc | FinalParameters | Parameter value should be final. | 136 |
| Error |
naming | LocalVariableName | Name 'L' must match pattern '^([a-z][a-zA-Z0-9]*|_)$'. | 137 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 143 |
| Error |
misc | FinalParameters | Parameter value should be final. | 143 |
| Error |
naming | LocalVariableName | Name 'L' must match pattern '^([a-z][a-zA-Z0-9]*|_)$'. | 144 |
edu/jiangxin/apktoolbox/convert/color/colorspace/CielabColorSpace.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
coding | MagicNumber | '3' is a magic number. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'fromCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'fromCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 27 |
| Error |
naming | LocalVariableName | Name 'L' must match pattern '^([a-z][a-zA-Z0-9]*|_)$'. | 29 |
| Error |
coding | MagicNumber | '116.0' is a magic number. | 29 |
| Error |
coding | MagicNumber | '16.0' is a magic number. | 29 |
| Error |
coding | MagicNumber | '500.0' is a magic number. | 30 |
| Error |
coding | MagicNumber | '200.0' is a magic number. | 31 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'toCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'toCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 35 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 36 |
| Error |
coding | MagicNumber | '16.0' is a magic number. | 37 |
| Error |
coding | MagicNumber | '116.0' is a magic number. | 37 |
| Error |
naming | LocalVariableName | Name 'X' must match pattern '^([a-z][a-zA-Z0-9]*|_)$'. | 38 |
| Error |
coding | MagicNumber | '500.0' is a magic number. | 38 |
| Error |
naming | LocalVariableName | Name 'Y' must match pattern '^([a-z][a-zA-Z0-9]*|_)$'. | 39 |
| Error |
naming | LocalVariableName | Name 'Z' must match pattern '^([a-z][a-zA-Z0-9]*|_)$'. | 40 |
| Error |
coding | MagicNumber | '200.0' is a magic number. | 40 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'fromRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'fromRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
misc | FinalParameters | Parameter rgbvalue should be final. | 45 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'toRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'toRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 51 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'getMaxValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'getMaxValue' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
| Error |
misc | FinalParameters | Parameter component should be final. | 57 |
| Error |
coding | MagicNumber | '128f' is a magic number. | 58 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'getMinValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'getMinValue' static/final/abstract/empty, or adding allowed annotation for the method. | 61 |
| Error |
misc | FinalParameters | Parameter component should be final. | 62 |
| Error |
whitespace | WhitespaceAround | '?' is not preceded with whitespace. | 63 |
| Error |
whitespace | WhitespaceAround | ':' is not preceded with whitespace. | 63 |
| Error |
coding | MagicNumber | '-128f' is a magic number. | 63 |
| Error |
design | DesignForExtension | Class 'CielabColorSpace' looks like designed for extension (can be subclassed), but the method 'getName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CielabColorSpace' final or making the method 'getName' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
| Error |
misc | FinalParameters | Parameter idx should be final. | 67 |
| Error |
misc | FinalParameters | Parameter x should be final. | 71 |
| Error |
coding | MagicNumber | '216.0' is a magic number. | 72 |
| Error |
coding | MagicNumber | '24389.0' is a magic number. | 72 |
| Error |
coding | MagicNumber | '841.0' is a magic number. | 75 |
| Error |
coding | MagicNumber | '108.0' is a magic number. | 75 |
| Error |
misc | FinalParameters | Parameter x should be final. | 79 |
| Error |
coding | MagicNumber | '6.0' is a magic number. | 80 |
| Error |
coding | MagicNumber | '29.0' is a magic number. | 80 |
| Error |
whitespace | WhitespaceAround | '*' is not followed by whitespace. | 81 |
| Error |
whitespace | WhitespaceAround | '*' is not preceded with whitespace. | 81 |
| Error |
whitespace | WhitespaceAround | '*' is not followed by whitespace. | 81 |
| Error |
whitespace | WhitespaceAround | '*' is not preceded with whitespace. | 81 |
| Error |
coding | MagicNumber | '108.0' is a magic number. | 83 |
| Error |
coding | MagicNumber | '841.0' is a magic number. | 83 |
edu/jiangxin/apktoolbox/convert/color/colorspace/CmykColorSpace.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
misc | FinalParameters | Parameter type should be final. | 7 |
| Error |
misc | FinalParameters | Parameter numComponents should be final. | 7 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Error |
design | DesignForExtension | Class 'CmykColorSpace' looks like designed for extension (can be subclassed), but the method 'toRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CmykColorSpace' final or making the method 'toRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 16 |
| Error |
coding | MagicNumber | '3' is a magic number. | 20 |
| Error |
design | DesignForExtension | Class 'CmykColorSpace' looks like designed for extension (can be subclassed), but the method 'fromRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CmykColorSpace' final or making the method 'fromRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
| Error |
misc | FinalParameters | Parameter rgbvalue should be final. | 30 |
| Error |
design | DesignForExtension | Class 'CmykColorSpace' looks like designed for extension (can be subclassed), but the method 'toCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CmykColorSpace' final or making the method 'toCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 44 |
| Error |
design | DesignForExtension | Class 'CmykColorSpace' looks like designed for extension (can be subclassed), but the method 'fromCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CmykColorSpace' final or making the method 'fromCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 50 |
| Error |
design | FinalClass | Class Holder should be declared as final. | 55 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
edu/jiangxin/apktoolbox/convert/color/colorspace/HsbColorSpace.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 3 |
| Error |
misc | FinalParameters | Parameter type should be final. | 8 |
| Error |
misc | FinalParameters | Parameter numComponents should be final. | 8 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
| Error |
design | DesignForExtension | Class 'HsbColorSpace' looks like designed for extension (can be subclassed), but the method 'toRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HsbColorSpace' final or making the method 'toRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 17 |
| Error |
coding | MagicNumber | '16' is a magic number. | 20 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 20 |
| Error |
coding | MagicNumber | '255f' is a magic number. | 20 |
| Error |
coding | MagicNumber | '8' is a magic number. | 21 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 21 |
| Error |
coding | MagicNumber | '255f' is a magic number. | 21 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 22 |
| Error |
coding | MagicNumber | '255f' is a magic number. | 22 |
| Error |
design | DesignForExtension | Class 'HsbColorSpace' looks like designed for extension (can be subclassed), but the method 'fromRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HsbColorSpace' final or making the method 'fromRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
misc | FinalParameters | Parameter rgbvalue should be final. | 27 |
| Error |
coding | MagicNumber | '255' is a magic number. | 28 |
| Error |
coding | MagicNumber | '255' is a magic number. | 29 |
| Error |
coding | MagicNumber | '255' is a magic number. | 30 |
| Error |
design | DesignForExtension | Class 'HsbColorSpace' looks like designed for extension (can be subclassed), but the method 'toCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HsbColorSpace' final or making the method 'toCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 35 |
| Error |
design | DesignForExtension | Class 'HsbColorSpace' looks like designed for extension (can be subclassed), but the method 'fromCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HsbColorSpace' final or making the method 'fromCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 41 |
| Error |
design | FinalClass | Class Holder should be declared as final. | 46 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
edu/jiangxin/apktoolbox/convert/color/colorspace/HslColorSpace.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
misc | FinalParameters | Parameter type should be final. | 7 |
| Error |
misc | FinalParameters | Parameter numComponents should be final. | 7 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Error |
design | DesignForExtension | Class 'HslColorSpace' looks like designed for extension (can be subclassed), but the method 'toRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HslColorSpace' final or making the method 'toRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 16 |
| Error |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 21 |
| Error |
coding | InnerAssignment | Inner assignments should be avoided. | 24 |
| Error |
coding | InnerAssignment | Inner assignments should be avoided. | 24 |
| Error |
coding | MagicNumber | '0.5f' is a magic number. | 26 |
| Error |
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 28 |
| Error |
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 28 |
| Error |
coding | MagicNumber | '3f' is a magic number. | 28 |
| Error |
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 30 |
| Error |
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 30 |
| Error |
coding | MagicNumber | '3f' is a magic number. | 30 |
| Error |
design | DesignForExtension | Class 'HslColorSpace' looks like designed for extension (can be subclassed), but the method 'fromRGB' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HslColorSpace' final or making the method 'fromRGB' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
misc | FinalParameters | Parameter rgbvalue should be final. | 37 |
| Error |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 45 |
| Error |
coding | InnerAssignment | Inner assignments should be avoided. | 49 |
| Error |
coding | MagicNumber | '0.5f' is a magic number. | 52 |
| Error |
coding | MagicNumber | '6f' is a magic number. | 54 |
| Error |
coding | MagicNumber | '4f' is a magic number. | 58 |
| Error |
coding | MagicNumber | '6f' is a magic number. | 60 |
| Error |
design | DesignForExtension | Class 'HslColorSpace' looks like designed for extension (can be subclassed), but the method 'toCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HslColorSpace' final or making the method 'toCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 66 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 67 |
| Error |
design | DesignForExtension | Class 'HslColorSpace' looks like designed for extension (can be subclassed), but the method 'fromCIEXYZ' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'HslColorSpace' final or making the method 'fromCIEXYZ' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
| Error |
misc | FinalParameters | Parameter colorvalue should be final. | 73 |
| Error |
misc | FinalParameters | Parameter p should be final. | 78 |
| Error |
misc | FinalParameters | Parameter q should be final. | 78 |
| Error |
misc | FinalParameters | Parameter t should be final. | 78 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 79 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 80 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 81 |
| Error |
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 81 |
| Error |
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 81 |
| Error |
coding | MagicNumber | '6f' is a magic number. | 81 |
| Error |
coding | MagicNumber | '6f' is a magic number. | 81 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 82 |
| Error |
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 82 |
| Error |
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 82 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 83 |
| Error |
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 83 |
| Error |
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 83 |
| Error |
coding | MagicNumber | '3f' is a magic number. | 83 |
| Error |
whitespace | WhitespaceAround | '/' is not followed by whitespace. | 83 |
| Error |
whitespace | WhitespaceAround | '/' is not preceded with whitespace. | 83 |
| Error |
coding | MagicNumber | '3f' is a magic number. | 83 |
| Error |
coding | MagicNumber | '6f' is a magic number. | 83 |
| Error |
design | FinalClass | Class Holder should be declared as final. | 87 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 88 |
edu/jiangxin/apktoolbox/convert/color/colortable/IColorTable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 4 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 6 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
edu/jiangxin/apktoolbox/convert/color/colortable/OrdinaryColorTable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'OrdinaryColorTable' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrdinaryColorTable' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 5 |
| Error |
design | DesignForExtension | Class 'OrdinaryColorTable' looks like designed for extension (can be subclassed), but the method 'getColumnNames' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrdinaryColorTable' final or making the method 'getColumnNames' static/final/abstract/empty, or adding allowed annotation for the method. | 10 |
| Error |
design | DesignForExtension | Class 'OrdinaryColorTable' looks like designed for extension (can be subclassed), but the method 'getTableRowData' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrdinaryColorTable' final or making the method 'getTableRowData' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
| Error |
design | DesignForExtension | Class 'OrdinaryColorTable' looks like designed for extension (can be subclassed), but the method 'getLabelIndex' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrdinaryColorTable' final or making the method 'getLabelIndex' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
| Error |
design | DesignForExtension | Class 'OrdinaryColorTable' looks like designed for extension (can be subclassed), but the method 'getHexIndex' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OrdinaryColorTable' final or making the method 'getHexIndex' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
| Error |
coding | MagicNumber | '3' is a magic number. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
edu/jiangxin/apktoolbox/convert/color/colortable/RalColorTable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'RalColorTable' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RalColorTable' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 5 |
| Error |
design | DesignForExtension | Class 'RalColorTable' looks like designed for extension (can be subclassed), but the method 'getColumnNames' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RalColorTable' final or making the method 'getColumnNames' static/final/abstract/empty, or adding allowed annotation for the method. | 10 |
| Error |
design | DesignForExtension | Class 'RalColorTable' looks like designed for extension (can be subclassed), but the method 'getTableRowData' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RalColorTable' final or making the method 'getTableRowData' static/final/abstract/empty, or adding allowed annotation for the method. | 15 |
| Error |
design | DesignForExtension | Class 'RalColorTable' looks like designed for extension (can be subclassed), but the method 'getLabelIndex' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RalColorTable' final or making the method 'getLabelIndex' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
| Error |
design | DesignForExtension | Class 'RalColorTable' looks like designed for extension (can be subclassed), but the method 'getHexIndex' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RalColorTable' final or making the method 'getHexIndex' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
| Error |
coding | MagicNumber | '3' is a magic number. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
edu/jiangxin/apktoolbox/convert/protobuf/supervised/AppMain.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 8 |
| Error |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 34 |
| Error |
whitespace | NoWhitespaceBefore | ';' is preceded with whitespace. | 34 |
| Error |
coding | HiddenField | 'code' hides a field. | 231 |
edu/jiangxin/apktoolbox/convert/protobuf/supervised/DescriptorCache.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 11 |
| Error |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
modifier | RedundantModifier | Redundant 'final' modifier. | 71 |
edu/jiangxin/apktoolbox/convert/protobuf/supervised/NoDescriptorFoundException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 |
edu/jiangxin/apktoolbox/convert/protobuf/supervised/ProtoToJson.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 52 |
| Error |
modifier | RedundantModifier | Redundant 'final' modifier. | 85 |
| Error |
modifier | RedundantModifier | Redundant 'final' modifier. | 86 |
| Error |
modifier | RedundantModifier | Redundant 'final' modifier. | 87 |
| Error |
coding | HiddenField | 'cache' hides a field. | 107 |
edu/jiangxin/apktoolbox/convert/protobuf/supervised/UncheckedDescriptorValidationException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 29 |
edu/jiangxin/apktoolbox/convert/protobuf/supervised/UncheckedInvalidProtocolBufferException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 28 |
edu/jiangxin/apktoolbox/convert/protobuf/unsupervised/BufferReader.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
misc | FinalParameters | Parameter buffer should be final. | 15 |
| Error |
coding | HiddenField | 'buffer' hides a field. | 15 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'getOffset' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'getOffset' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'readVarInt' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'readVarInt' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'readBuffer' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'readBuffer' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
| Error |
misc | FinalParameters | Parameter length should be final. | 30 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'trySkipGrpcHeader' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'trySkipGrpcHeader' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
| Error |
coding | MagicNumber | '5' is a magic number. | 39 |
| Error |
coding | MagicNumber | '4' is a magic number. | 42 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'leftBytes' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'leftBytes' static/final/abstract/empty, or adding allowed annotation for the method. | 50 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 50 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'checkByte' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'checkByte' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
| Error |
misc | FinalParameters | Parameter length should be final. | 54 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'checkpoint' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'checkpoint' static/final/abstract/empty, or adding allowed annotation for the method. | 63 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
| Error |
design | DesignForExtension | Class 'BufferReader' looks like designed for extension (can be subclassed), but the method 'resetToCheckpoint' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BufferReader' final or making the method 'resetToCheckpoint' static/final/abstract/empty, or adding allowed annotation for the method. | 67 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
edu/jiangxin/apktoolbox/convert/protobuf/unsupervised/ByteUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 5 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 7 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 7 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 11 |
| Error |
misc | FinalParameters | Parameter byteOrder should be final. | 11 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 15 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 19 |
| Error |
misc | FinalParameters | Parameter byteOrder should be final. | 19 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 23 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 27 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 27 |
| Error |
misc | FinalParameters | Parameter byteOrder should be final. | 27 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 31 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 35 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 35 |
| Error |
misc | FinalParameters | Parameter byteOrder should be final. | 35 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 39 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 39 |
| Error |
misc | FinalParameters | Parameter start should be final. | 39 |
| Error |
misc | FinalParameters | Parameter byteOrder should be final. | 39 |
| Error |
coding | MagicNumber | '0xff' is a magic number. | 44 |
| Error |
coding | MagicNumber | '0xff' is a magic number. | 49 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 56 |
| Error |
misc | FinalParameters | Parameter start should be final. | 56 |
| Error |
misc | FinalParameters | Parameter byteOrder should be final. | 56 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 58 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 58 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 59 |
| Error |
coding | MagicNumber | '8' is a magic number. | 59 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 59 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 60 |
| Error |
coding | MagicNumber | '16' is a magic number. | 60 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 60 |
| Error |
coding | MagicNumber | '3' is a magic number. | 61 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 61 |
| Error |
coding | MagicNumber | '24' is a magic number. | 61 |
| Error |
coding | MagicNumber | '3' is a magic number. | 63 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 63 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 63 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 64 |
| Error |
coding | MagicNumber | '8' is a magic number. | 64 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 64 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 65 |
| Error |
coding | MagicNumber | '16' is a magic number. | 65 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 65 |
| Error |
coding | MagicNumber | '0xFF' is a magic number. | 66 |
| Error |
coding | MagicNumber | '24' is a magic number. | 66 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 71 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 71 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 79 |
| Error |
misc | FinalParameters | Parameter hexString should be final. | 79 |
| Error |
whitespace | WhitespaceAround | '-' is not followed by whitespace. | 89 |
| Error |
whitespace | WhitespaceAround | '-' is not preceded with whitespace. | 89 |
| Error |
coding | MagicNumber | '16' is a magic number. | 90 |
| Error |
coding | MagicNumber | '4' is a magic number. | 90 |
| Error |
coding | MagicNumber | '16' is a magic number. | 91 |
edu/jiangxin/apktoolbox/convert/protobuf/unsupervised/DecoderResult.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 11 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 15 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 19 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 23 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 27 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'getByteRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'getByteRange' static/final/abstract/empty, or adding allowed annotation for the method. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 32 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'setByteRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'setByteRange' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
misc | FinalParameters | Parameter byteRange should be final. | 36 |
| Error |
coding | HiddenField | 'byteRange' hides a field. | 36 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'getFieldNumber' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'getFieldNumber' static/final/abstract/empty, or adding allowed annotation for the method. | 40 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'setFieldNumber' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'setFieldNumber' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
| Error |
misc | FinalParameters | Parameter fieldNumber should be final. | 44 |
| Error |
coding | HiddenField | 'fieldNumber' hides a field. | 44 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'getType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'getType' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'setType' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'setType' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
| Error |
misc | FinalParameters | Parameter type should be final. | 52 |
| Error |
coding | HiddenField | 'type' hides a field. | 52 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'getContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'getContent' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'setContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'setContent' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
| Error |
misc | FinalParameters | Parameter content should be final. | 60 |
| Error |
coding | HiddenField | 'content' hides a field. | 60 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'getSubResults' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'getSubResults' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 64 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'setSubResults' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'setSubResults' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 68 |
| Error |
misc | FinalParameters | Parameter subResults should be final. | 68 |
| Error |
coding | HiddenField | 'subResults' hides a field. | 68 |
| Error |
design | DesignForExtension | Class 'DecoderResult' looks like designed for extension (can be subclassed), but the method 'toJson' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DecoderResult' final or making the method 'toJson' static/final/abstract/empty, or adding allowed annotation for the method. | 72 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 72 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 85 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 91 |
| Error |
misc | FinalParameters | Parameter type should be final. | 91 |
edu/jiangxin/apktoolbox/convert/protobuf/unsupervised/ProtobufConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
design | DesignForExtension | Class 'ProtobufConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProtobufConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
| Error |
coding | MagicNumber | '200' is a magic number. | 46 |
| Error |
coding | MagicNumber | '500' is a magic number. | 46 |
| Error |
coding | MagicNumber | '200' is a magic number. | 54 |
| Error |
coding | MagicNumber | '500' is a magic number. | 54 |
edu/jiangxin/apktoolbox/convert/protobuf/unsupervised/ProtobufDecoder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 28 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 34 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 34 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 48 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 54 |
| Error |
misc | FinalParameters | Parameter buffer should be final. | 54 |
| Error |
coding | MagicNumber | '0b111' is a magic number. | 66 |
| Error |
coding | MagicNumber | '3' is a magic number. | 67 |
| Error |
coding | MagicNumber | '4' is a magic number. | 76 |
| Error |
coding | MagicNumber | '8' is a magic number. | 78 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 102 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 108 |
| Error |
misc | FinalParameters | Parameter part should be final. | 108 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 155 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 159 |
| Error |
misc | FinalParameters | Parameter value should be final. | 159 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'value'. | 159 |
| Error |
coding | MagicNumber | '3' is a magic number. | 164 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 184 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 188 |
| Error |
misc | FinalParameters | Parameter value should be final. | 188 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'value'. | 188 |
| Error |
coding | MagicNumber | '16' is a magic number. | 190 |
| Error |
coding | MagicNumber | '3' is a magic number. | 193 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 213 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 217 |
| Error |
misc | FinalParameters | Parameter value should be final. | 217 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'value'. | 217 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 235 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 239 |
| Error |
misc | FinalParameters | Parameter value should be final. | 239 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'value'. | 239 |
| Error |
coding | MagicNumber | '3' is a magic number. | 240 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 258 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 264 |
| Error |
misc | FinalParameters | Parameter uintValue should be final. | 264 |
| Error |
coding | MagicNumber | '16' is a magic number. | 265 |
| Error |
coding | MagicNumber | '16' is a magic number. | 266 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 272 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 279 |
| Error |
misc | FinalParameters | Parameter string should be final. | 279 |
| Error |
misc | FinalParameters | Parameter charsetName should be final. | 279 |
| Error |
coding | MagicNumber | '0xff' is a magic number. | 286 |
| Error |
coding | MagicNumber | '16' is a magic number. | 286 |
edu/jiangxin/apktoolbox/convert/protobuf/unsupervised/VarintUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 7 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 9 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 15 |
| Error |
misc | FinalParameters | Parameter bigInteger should be final. | 15 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 15 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 24 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 31 |
| Error |
misc | FinalParameters | Parameter buffer should be final. | 31 |
| Error |
misc | FinalParameters | Parameter offset should be final. | 31 |
| Error |
coding | MagicNumber | '0x7f' is a magic number. | 45 |
| Error |
coding | MagicNumber | '7' is a magic number. | 46 |
| Error |
coding | MagicNumber | '0xff' is a magic number. | 48 |
| Error |
coding | MagicNumber | '128' is a magic number. | 48 |
| Error |
coding | MagicNumber | '8' is a magic number. | 48 |
| Error |
coding | MagicNumber | '7' is a magic number. | 52 |
edu/jiangxin/apktoolbox/convert/relationship/RelationShipConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 6 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
naming | ConstantName | Name 'dataMap' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
design | DesignForExtension | Class 'RelationShipConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'RelationShipConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
| Error |
coding | MagicNumber | '5' is a magic number. | 50 |
| Error |
coding | MagicNumber | '5' is a magic number. | 50 |
| Error |
coding | MagicNumber | '5' is a magic number. | 50 |
| Error |
coding | MagicNumber | '5' is a magic number. | 50 |
| Error |
coding | MagicNumber | '4' is a magic number. | 53 |
| Error |
coding | MagicNumber | '3' is a magic number. | 88 |
| Error |
coding | MagicNumber | '3' is a magic number. | 95 |
| Error |
coding | MagicNumber | '3' is a magic number. | 113 |
| Error |
coding | MagicNumber | '4' is a magic number. | 120 |
| Error |
coding | MagicNumber | '3' is a magic number. | 138 |
| Error |
coding | MagicNumber | '5' is a magic number. | 145 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 163 |
| Error |
coding | MagicNumber | '15' is a magic number. | 165 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 172 |
| Error |
misc | FinalParameters | Parameter text should be final. | 172 |
| Error |
coding | MagicNumber | '30' is a magic number. | 174 |
| Error |
misc | FinalParameters | Parameter e should be final. | 180 |
| Error |
misc | FinalParameters | Parameter relationString should be final. | 220 |
| Error |
misc | FinalParameters | Parameter now should be final. | 224 |
| Error |
misc | FinalParameters | Parameter what should be final. | 224 |
| Error |
misc | FinalParameters | Parameter possibleRelation should be final. | 232 |
| Error |
misc | FinalParameters | Parameter possibleRelation should be final. | 236 |
edu/jiangxin/apktoolbox/convert/time/TimeConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.Calendar.*. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
naming | MemberName | Name 'SDF' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 42 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 45 |
| Error |
naming | ConstantName | Name 'sortedTimeZones' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 45 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 53 |
| Error |
design | DesignForExtension | Class 'TimeConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'TimeConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 57 |
| Error |
coding | MagicNumber | '3' is a magic number. | 66 |
| Error |
coding | MagicNumber | '3' is a magic number. | 69 |
| Error |
coding | MagicNumber | '3' is a magic number. | 72 |
| Error |
coding | MagicNumber | '40' is a magic number. | 89 |
| Error |
coding | MagicNumber | '150' is a magic number. | 95 |
| Error |
coding | MagicNumber | '25' is a magic number. | 95 |
| Error |
coding | MagicNumber | '20' is a magic number. | 110 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 174 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 180 |
| Error |
coding | MagicNumber | '70' is a magic number. | 235 |
| Error |
coding | MagicNumber | '70' is a magic number. | 241 |
| Error |
coding | MagicNumber | '10' is a magic number. | 246 |
| Error |
misc | FinalParameters | Parameter e should be final. | 272 |
| Error |
misc | FinalParameters | Parameter e should be final. | 287 |
edu/jiangxin/apktoolbox/convert/zh2unicode/Zh2UnicodeConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 6 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Error |
design | DesignForExtension | Class 'Zh2UnicodeConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'Zh2UnicodeConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
| Error |
coding | MagicNumber | '200' is a magic number. | 57 |
| Error |
coding | MagicNumber | '500' is a magic number. | 57 |
| Error |
coding | MagicNumber | '200' is a magic number. | 72 |
| Error |
coding | MagicNumber | '500' is a magic number. | 72 |
| Error |
misc | FinalParameters | Parameter str should be final. | 99 |
| Error |
coding | MagicNumber | '0xff' is a magic number. | 110 |
| Error |
coding | MagicNumber | '0xff' is a magic number. | 113 |
| Error |
misc | FinalParameters | Parameter unicodeStr should be final. | 120 |
| Error |
coding | MagicNumber | '16' is a magic number. | 127 |
edu/jiangxin/apktoolbox/file/EncodeConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 12 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 13 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.event.*. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
| Error |
design | DesignForExtension | Class 'EncodeConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EncodeConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
| Error |
design | FinalClass | Class ConvertButtonActionListener should be declared as final. | 128 |
| Error |
misc | FinalParameters | Parameter e should be final. | 130 |
edu/jiangxin/apktoolbox/file/OsConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
design | DesignForExtension | Class 'OsConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'OsConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
misc | FinalParameters | Parameter e should be final. | 106 |
| Error |
misc | FinalParameters | Parameter showName should be final. | 124 |
| Error |
coding | MissingSwitchDefault | switch without "default" clause. | 125 |
edu/jiangxin/apktoolbox/file/batchrename/BatchRenamePanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 58 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 60 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 65 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 67 |
| Error |
design | DesignForExtension | Class 'BatchRenamePanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BatchRenamePanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 71 |
| Error |
coding | MagicNumber | '20' is a magic number. | 103 |
| Error |
sizes | MethodLength | Method createRulePanel length is 156 lines (max allowed is 150). | 152 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 162 |
| Error |
coding | MagicNumber | '10' is a magic number. | 162 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 162 |
| Error |
coding | MagicNumber | '3' is a magic number. | 162 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 165 |
| Error |
coding | MagicNumber | '10' is a magic number. | 165 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 165 |
| Error |
coding | MagicNumber | '3' is a magic number. | 165 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 168 |
| Error |
coding | MagicNumber | '10' is a magic number. | 168 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 168 |
| Error |
coding | MagicNumber | '3' is a magic number. | 168 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 171 |
| Error |
coding | MagicNumber | '10' is a magic number. | 171 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 171 |
| Error |
coding | MagicNumber | '3' is a magic number. | 171 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 174 |
| Error |
coding | MagicNumber | '10' is a magic number. | 174 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 174 |
| Error |
coding | MagicNumber | '3' is a magic number. | 174 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 177 |
| Error |
coding | MagicNumber | '10' is a magic number. | 177 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 177 |
| Error |
coding | MagicNumber | '3' is a magic number. | 177 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 193 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 200 |
| Error |
coding | MagicNumber | '4' is a magic number. | 209 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 216 |
| Error |
coding | MagicNumber | '3' is a magic number. | 233 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 247 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 276 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 293 |
| Error |
misc | FinalParameters | Parameter e should be final. | 339 |
| Error |
misc | FinalParameters | Parameter file should be final. | 369 |
| Error |
misc | FinalParameters | Parameter oldFileName should be final. | 403 |
| Error |
misc | FinalParameters | Parameter file should be final. | 427 |
| Error |
coding | MissingSwitchDefault | switch without "default" clause. | 432 |
| Error |
misc | FinalParameters | Parameter oldFileName should be final. | 446 |
| Error |
misc | FinalParameters | Parameter oldFileName should be final. | 452 |
edu/jiangxin/apktoolbox/file/checksum/CalculateType.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 4 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
misc | FinalParameters | Parameter id should be final. | 14 |
| Error |
coding | HiddenField | 'id' hides a field. | 14 |
| Error |
misc | FinalParameters | Parameter name should be final. | 14 |
| Error |
coding | HiddenField | 'name' hides a field. | 14 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
edu/jiangxin/apktoolbox/file/checksum/ChecksumPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - edu.jiangxin.apktoolbox.file.checksum.panel.*. | 3 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
design | DesignForExtension | Class 'ChecksumPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChecksumPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
edu/jiangxin/apktoolbox/file/checksum/panel/CompareFilesPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
design | DesignForExtension | Class 'CompareFilesPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CompareFilesPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
| Error |
coding | MagicNumber | '100' is a magic number. | 85 |
| Error |
coding | MagicNumber | '25' is a magic number. | 85 |
| Error |
coding | MagicNumber | '16' is a magic number. | 88 |
edu/jiangxin/apktoolbox/file/checksum/panel/FileChecksumPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
design | DesignForExtension | Class 'FileChecksumPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FileChecksumPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
| Error |
coding | MagicNumber | '100' is a magic number. | 175 |
| Error |
misc | FinalParameters | Parameter file should be final. | 185 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 187 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 187 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 187 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 187 |
| Error |
coding | MagicNumber | '5' is a magic number. | 189 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 192 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 192 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 192 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 192 |
| Error |
coding | MagicNumber | '5' is a magic number. | 198 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 201 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 201 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 201 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 201 |
| Error |
coding | MagicNumber | '15' is a magic number. | 207 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 210 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 210 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 210 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 210 |
| Error |
coding | MagicNumber | '15' is a magic number. | 216 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 219 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 219 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 219 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 219 |
| Error |
coding | MagicNumber | '15' is a magic number. | 225 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 228 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 228 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 228 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 228 |
| Error |
coding | MagicNumber | '15' is a magic number. | 234 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 237 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 237 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 237 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 237 |
| Error |
coding | MagicNumber | '15' is a magic number. | 243 |
| Error |
whitespace | WhitespaceAfter | '->' is not followed by whitespace. | 246 |
| Error |
whitespace | WhitespaceAround | '->' is not followed by whitespace. | 246 |
| Error |
whitespace | WhitespaceAround | '->' is not preceded with whitespace. | 246 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 246 |
| Error |
coding | MagicNumber | '15' is a magic number. | 252 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 260 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 264 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 268 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 272 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 276 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 280 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 284 |
edu/jiangxin/apktoolbox/file/checksum/panel/StringHashPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
design | DesignForExtension | Class 'StringHashPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'StringHashPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
| Error |
coding | MagicNumber | '5' is a magic number. | 63 |
| Error |
coding | MagicNumber | '4' is a magic number. | 63 |
| Error |
coding | MagicNumber | '100' is a magic number. | 166 |
| Error |
misc | FinalParameters | Parameter text should be final. | 176 |
| Error |
coding | MagicNumber | '10' is a magic number. | 180 |
| Error |
coding | MagicNumber | '15' is a magic number. | 189 |
| Error |
coding | MagicNumber | '15' is a magic number. | 198 |
| Error |
coding | MagicNumber | '15' is a magic number. | 207 |
| Error |
coding | MagicNumber | '15' is a magic number. | 216 |
| Error |
coding | MagicNumber | '15' is a magic number. | 225 |
| Error |
coding | MagicNumber | '15' is a magic number. | 234 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 242 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 246 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 250 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 254 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 258 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 262 |
| Error |
blocks | AvoidNestedBlocks | Avoid nested blocks. | 268 |
edu/jiangxin/apktoolbox/file/checksum/panel/VerifyChecksumPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
design | DesignForExtension | Class 'VerifyChecksumPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'VerifyChecksumPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
| Error |
coding | MagicNumber | '5' is a magic number. | 49 |
| Error |
coding | MagicNumber | '4' is a magic number. | 49 |
| Error |
coding | MagicNumber | '5' is a magic number. | 64 |
| Error |
coding | MagicNumber | '4' is a magic number. | 64 |
| Error |
coding | MagicNumber | '100' is a magic number. | 104 |
| Error |
coding | MagicNumber | '25' is a magic number. | 104 |
| Error |
coding | MagicNumber | '16' is a magic number. | 107 |
| Error |
misc | FinalParameters | Parameter summary should be final. | 118 |
edu/jiangxin/apktoolbox/file/core/EncoderConvert.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 28 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 38 |
| Error |
misc | FinalParameters | Parameter srcEncoder should be final. | 38 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 38 |
| Error |
misc | FinalParameters | Parameter desEncoder should be final. | 38 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 78 |
| Error |
misc | FinalParameters | Parameter fileString should be final. | 83 |
| Error |
misc | FinalParameters | Parameter srcEncoder should be final. | 83 |
| Error |
misc | FinalParameters | Parameter desEncoder should be final. | 83 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 89 |
| Error |
misc | FinalParameters | Parameter srcDirString should be final. | 96 |
| Error |
misc | FinalParameters | Parameter srcEncoder should be final. | 96 |
| Error |
misc | FinalParameters | Parameter desDirString should be final. | 96 |
| Error |
misc | FinalParameters | Parameter desEncoder should be final. | 96 |
| Error |
misc | FinalParameters | Parameter suffix should be final. | 97 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 117 |
| Error |
misc | FinalParameters | Parameter srcDirString should be final. | 123 |
| Error |
misc | FinalParameters | Parameter srcEncoder should be final. | 123 |
| Error |
misc | FinalParameters | Parameter desDirString should be final. | 123 |
| Error |
misc | FinalParameters | Parameter desEncoder should be final. | 123 |
edu/jiangxin/apktoolbox/file/core/EncoderDetector.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 30 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
| Error |
misc | FinalParameters | Parameter fileName should be final. | 36 |
| Error |
coding | MagicNumber | '4096' is a magic number. | 77 |
edu/jiangxin/apktoolbox/file/core/FileFilterWrapper.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | UnusedImports | Unused import - org.apache.commons.io.filefilter.FileFileFilter. | 4 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 21 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
| Error |
misc | FinalParameters | Parameter args should be final. | 48 |
edu/jiangxin/apktoolbox/file/core/FileProcess.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | UnusedImports | Unused import - java.io.BufferedReader. | 5 |
| Error |
imports | UnusedImports | Unused import - java.io.InputStreamReader. | 10 |
| Error |
imports | UnusedImports | Unused import - org.apache.commons.lang3.StringUtils. | 12 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 16 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 24 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 25 |
| Error |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 28 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 30 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 36 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 36 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 56 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 58 |
| Error |
misc | FinalParameters | Parameter srcDirString should be final. | 63 |
| Error |
misc | FinalParameters | Parameter desDirString should be final. | 63 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 93 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 95 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 101 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 101 |
| Error |
misc | FinalParameters | Parameter isOverride should be final. | 101 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 118 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 120 |
| Error |
misc | FinalParameters | Parameter dir should be final. | 124 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 148 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 150 |
| Error |
misc | FinalParameters | Parameter dirs should be final. | 154 |
| Error |
coding | SimplifyBooleanExpression | Expression can be simplified. | 157 |
edu/jiangxin/apktoolbox/file/core/OsPatternConvert.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 20 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 28 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
| Error |
javadoc | JavadocMethod | Unused @param tag for 'options:换行符，比如:\n,\r,\r\n'. | 38 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 40 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 40 |
| Error |
misc | FinalParameters | Parameter options should be final. | 40 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'options'. | 40 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 90 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 94 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 94 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 101 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 105 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 105 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 112 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 116 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 116 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 123 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 127 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 127 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 133 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 137 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 137 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 143 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 147 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 147 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 153 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 157 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 157 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 163 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 167 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 167 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 173 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 177 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 177 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 189 |
| Error |
misc | FinalParameters | Parameter srcFileString should be final. | 194 |
| Error |
misc | FinalParameters | Parameter desFileString should be final. | 194 |
| Error |
misc | FinalParameters | Parameter pattern should be final. | 194 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 231 |
| Error |
misc | FinalParameters | Parameter fileString should be final. | 236 |
| Error |
misc | FinalParameters | Parameter pattern should be final. | 236 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 245 |
| Error |
misc | FinalParameters | Parameter srcDirString should be final. | 252 |
| Error |
misc | FinalParameters | Parameter desDirString should be final. | 252 |
| Error |
misc | FinalParameters | Parameter pattern should be final. | 252 |
| Error |
misc | FinalParameters | Parameter suffix should be final. | 252 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 281 |
| Error |
misc | FinalParameters | Parameter srcDirString should be final. | 287 |
| Error |
misc | FinalParameters | Parameter desDirString should be final. | 287 |
| Error |
misc | FinalParameters | Parameter pattern should be final. | 287 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 296 |
| Error |
misc | FinalParameters | Parameter files should be final. | 301 |
| Error |
misc | FinalParameters | Parameter pattern should be final. | 301 |
edu/jiangxin/apktoolbox/file/duplicate/DuplicateFilesConstants.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 3 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
coding | MagicNumber | '255' is a magic number. | 28 |
| Error |
coding | MagicNumber | '182' is a magic number. | 28 |
| Error |
coding | MagicNumber | '193' is a magic number. | 28 |
| Error |
coding | MagicNumber | '30' is a magic number. | 28 |
| Error |
coding | MagicNumber | '123' is a magic number. | 29 |
| Error |
coding | MagicNumber | '104' is a magic number. | 29 |
| Error |
coding | MagicNumber | '238' is a magic number. | 29 |
| Error |
coding | MagicNumber | '30' is a magic number. | 29 |
| Error |
coding | MagicNumber | '127' is a magic number. | 30 |
| Error |
coding | MagicNumber | '255' is a magic number. | 30 |
| Error |
coding | MagicNumber | '170' is a magic number. | 30 |
| Error |
coding | MagicNumber | '30' is a magic number. | 30 |
| Error |
coding | MagicNumber | '255' is a magic number. | 31 |
| Error |
coding | MagicNumber | '255' is a magic number. | 31 |
| Error |
coding | MagicNumber | '30' is a magic number. | 31 |
edu/jiangxin/apktoolbox/file/duplicate/DuplicateFilesTableCellRenderer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 3 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 5 |
| Error |
design | DesignForExtension | Class 'DuplicateFilesTableCellRenderer' looks like designed for extension (can be subclassed), but the method 'getTableCellRendererComponent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DuplicateFilesTableCellRenderer' final or making the method 'getTableCellRendererComponent' static/final/abstract/empty, or adding allowed annotation for the method. | 8 |
| Error |
misc | FinalParameters | Parameter table should be final. | 9 |
| Error |
misc | FinalParameters | Parameter value should be final. | 9 |
| Error |
misc | FinalParameters | Parameter isSelected should be final. | 9 |
| Error |
misc | FinalParameters | Parameter hasFocus should be final. | 9 |
| Error |
misc | FinalParameters | Parameter row should be final. | 9 |
| Error |
misc | FinalParameters | Parameter column should be final. | 9 |
edu/jiangxin/apktoolbox/file/duplicate/DuplicateFilesTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 7 |
| Error |
misc | FinalParameters | Parameter data should be final. | 7 |
| Error |
misc | FinalParameters | Parameter columnNames should be final. | 7 |
| Error |
design | DesignForExtension | Class 'DuplicateFilesTableModel' looks like designed for extension (can be subclassed), but the method 'isCellEditable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DuplicateFilesTableModel' final or making the method 'isCellEditable' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
| Error |
misc | FinalParameters | Parameter row should be final. | 12 |
| Error |
misc | FinalParameters | Parameter column should be final. | 12 |
edu/jiangxin/apktoolbox/file/duplicate/DuplicateSearchPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 12 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 14 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 19 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 52 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 54 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 56 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 58 |
| Error |
modifier | ModifierOrder | 'private' modifier out of order with the JLS suggestions. | 58 |
| Error |
design | DesignForExtension | Class 'DuplicateSearchPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DuplicateSearchPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
| Error |
design | DesignForExtension | Class 'DuplicateSearchPanel' looks like designed for extension (can be subclassed), but the method 'getComparedKey' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DuplicateSearchPanel' final or making the method 'getComparedKey' static/final/abstract/empty, or adding allowed annotation for the method. | 158 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 158 |
| Error |
misc | FinalParameters | Parameter file should be final. | 158 |
| Error |
misc | FinalParameters | Parameter e should be final. | 192 |
| Error |
misc | FinalParameters | Parameter actionEvent should be final. | 231 |
| Error |
misc | FinalParameters | Parameter e should be final. | 320 |
| Error |
misc | FinalParameters | Parameter groupIndex should be final. | 356 |
| Error |
misc | FinalParameters | Parameter file should be final. | 356 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 368 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 369 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 370 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 371 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 373 |
| Error |
misc | FinalParameters | Parameter extensions should be final. | 373 |
| Error |
coding | HiddenField | 'extensions' hides a field. | 373 |
| Error |
misc | FinalParameters | Parameter isRecursiveSearched should be final. | 373 |
| Error |
coding | HiddenField | 'isRecursiveSearched' hides a field. | 373 |
| Error |
misc | FinalParameters | Parameter isHiddenFileSearched should be final. | 373 |
| Error |
coding | HiddenField | 'isHiddenFileSearched' hides a field. | 373 |
| Error |
misc | FinalParameters | Parameter duplicateFileGroupMap should be final. | 373 |
| Error |
coding | HiddenField | 'duplicateFileGroupMap' hides a field. | 373 |
edu/jiangxin/apktoolbox/file/password/recovery/RecoveryPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - edu.jiangxin.apktoolbox.file.password.recovery.checker.*. | 6 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 18 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 47 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 49 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 51 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 53 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 55 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 57 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 59 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 72 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 73 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 75 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 77 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 79 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 81 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 83 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 85 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 87 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 89 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 91 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
| Error |
coding | MagicNumber | '3' is a magic number. | 100 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 115 |
| Error |
coding | MagicNumber | '10' is a magic number. | 204 |
| Error |
coding | MagicNumber | '10' is a magic number. | 206 |
| Error |
coding | MagicNumber | '9' is a magic number. | 225 |
| Error |
coding | MagicNumber | '6' is a magic number. | 229 |
| Error |
coding | MagicNumber | '9' is a magic number. | 229 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 362 |
| Error |
misc | FinalParameters | Parameter password should be final. | 362 |
| Error |
misc | FinalParameters | Parameter password should be final. | 373 |
| Error |
coding | MagicNumber | '20' is a magic number. | 378 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 391 |
| Error |
misc | FinalParameters | Parameter currentState should be final. | 391 |
| Error |
coding | HiddenField | 'currentState' hides a field. | 391 |
| Error |
misc | FinalParameters | Parameter enable should be final. | 416 |
| Error |
misc | FinalParameters | Parameter container should be final. | 422 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 438 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 442 |
| Error |
misc | FinalParameters | Parameter maxValue should be final. | 442 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 449 |
| Error |
misc | FinalParameters | Parameter value should be final. | 453 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 460 |
| Error |
misc | FinalParameters | Parameter password should be final. | 460 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 464 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 486 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 490 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 494 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 498 |
edu/jiangxin/apktoolbox/file/password/recovery/State.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 4 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
edu/jiangxin/apktoolbox/file/password/recovery/category/CategoryFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
design | FinalClass | Class CategoryFactory should be declared as final. | 10 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
| Error |
misc | FinalParameters | Parameter categoryType should be final. | 14 |
edu/jiangxin/apktoolbox/file/password/recovery/category/CategoryType.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 4 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
edu/jiangxin/apktoolbox/file/password/recovery/category/ICategory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 6 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
edu/jiangxin/apktoolbox/file/password/recovery/category/bruteforce/BruteForceFuture.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
| Error |
misc | FinalParameters | Parameter taskCount should be final. | 25 |
| Error |
coding | HiddenField | 'taskCount' hides a field. | 25 |
| Error |
design | DesignForExtension | Class 'BruteForceFuture' looks like designed for extension (can be subclassed), but the method 'set' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceFuture' final or making the method 'set' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
misc | FinalParameters | Parameter result should be final. | 29 |
| Error |
coding | HiddenField | 'result' hides a field. | 29 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 38 |
| Error |
design | DesignForExtension | Class 'BruteForceFuture' looks like designed for extension (can be subclassed), but the method 'get' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceFuture' final or making the method 'get' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
| Error |
design | DesignForExtension | Class 'BruteForceFuture' looks like designed for extension (can be subclassed), but the method 'isDone' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceFuture' final or making the method 'isDone' static/final/abstract/empty, or adding allowed annotation for the method. | 68 |
| Error |
design | DesignForExtension | Class 'BruteForceFuture' looks like designed for extension (can be subclassed), but the method 'cancel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceFuture' final or making the method 'cancel' static/final/abstract/empty, or adding allowed annotation for the method. | 73 |
| Error |
misc | FinalParameters | Parameter mayInterruptIfRunning should be final. | 74 |
| Error |
design | DesignForExtension | Class 'BruteForceFuture' looks like designed for extension (can be subclassed), but the method 'isCancelled' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceFuture' final or making the method 'isCancelled' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
| Error |
design | DesignForExtension | Class 'BruteForceFuture' looks like designed for extension (can be subclassed), but the method 'get' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceFuture' final or making the method 'get' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
| Error |
misc | FinalParameters | Parameter timeout should be final. | 85 |
| Error |
misc | FinalParameters | Parameter unit should be final. | 85 |
edu/jiangxin/apktoolbox/file/password/recovery/category/bruteforce/BruteForceProxy.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 12 |
| Error |
design | FinalClass | Class BruteForceProxy should be declared as final. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
design | FinalClass | Class BruteForceProxyHolder should be declared as final. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
naming | ConstantName | Name 'instance' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 25 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
| Error |
misc | FinalParameters | Parameter numThreads should be final. | 35 |
| Error |
misc | FinalParameters | Parameter passwordLength should be final. | 35 |
| Error |
misc | FinalParameters | Parameter checker should be final. | 35 |
| Error |
misc | FinalParameters | Parameter charsSet should be final. | 35 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 35 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 57 |
| Error |
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 74 |
| Error |
coding | MagicNumber | '100' is a magic number. | 104 |
| Error |
misc | FinalParameters | Parameter charSetSize should be final. | 113 |
| Error |
misc | FinalParameters | Parameter length should be final. | 113 |
| Error |
misc | FinalParameters | Parameter maxThreadCount should be final. | 113 |
edu/jiangxin/apktoolbox/file/password/recovery/category/bruteforce/BruteForceRunnable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
design | VisibilityModifier | Variable 'panel' must be private and have accessor methods. | 15 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
misc | FinalParameters | Parameter taskId should be final. | 17 |
| Error |
coding | HiddenField | 'taskId' hides a field. | 17 |
| Error |
misc | FinalParameters | Parameter consts should be final. | 17 |
| Error |
coding | HiddenField | 'consts' hides a field. | 17 |
| Error |
misc | FinalParameters | Parameter bruteForceFuture should be final. | 17 |
| Error |
coding | HiddenField | 'bruteForceFuture' hides a field. | 17 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 17 |
| Error |
coding | HiddenField | 'panel' hides a field. | 17 |
| Error |
design | DesignForExtension | Class 'BruteForceRunnable' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceRunnable' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
| Error |
design | DesignForExtension | Class 'BruteForceRunnable' looks like designed for extension (can be subclassed), but the method 'findPasswordInRange' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceRunnable' final or making the method 'findPasswordInRange' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
| Error |
misc | FinalParameters | Parameter rangeBegin should be final. | 37 |
| Error |
misc | FinalParameters | Parameter rangeEnd should be final. | 37 |
| Error |
misc | FinalParameters | Parameter checker should be final. | 37 |
| Error |
design | DesignForExtension | Class 'BruteForceRunnable' looks like designed for extension (can be subclassed), but the method 'transformDecToBaseN' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceRunnable' final or making the method 'transformDecToBaseN' static/final/abstract/empty, or adding allowed annotation for the method. | 78 |
| Error |
misc | FinalParameters | Parameter numInDec should be final. | 78 |
| Error |
misc | FinalParameters | Parameter numArrayInBaseN should be final. | 78 |
| Error |
misc | FinalParameters | Parameter candidateChars should be final. | 88 |
| Error |
misc | FinalParameters | Parameter charsArray should be final. | 110 |
edu/jiangxin/apktoolbox/file/password/recovery/category/bruteforce/BruteForceTaskParam.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
design | VisibilityModifier | Variable 'numThreads' must be private and have accessor methods. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
| Error |
design | VisibilityModifier | Variable 'passwordLength' must be private and have accessor methods. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
| Error |
design | VisibilityModifier | Variable 'passwordRangeSize' must be private and have accessor methods. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
design | VisibilityModifier | Variable 'passwordSubRangeSize' must be private and have accessor methods. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
design | VisibilityModifier | Variable 'checker' must be private and have accessor methods. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
design | VisibilityModifier | Variable 'charsSet' must be private and have accessor methods. | 11 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 13 |
| Error |
misc | FinalParameters | Parameter numThreads should be final. | 13 |
| Error |
coding | HiddenField | 'numThreads' hides a field. | 13 |
| Error |
misc | FinalParameters | Parameter passwordLength should be final. | 13 |
| Error |
coding | HiddenField | 'passwordLength' hides a field. | 13 |
| Error |
misc | FinalParameters | Parameter checker should be final. | 13 |
| Error |
coding | HiddenField | 'checker' hides a field. | 13 |
| Error |
misc | FinalParameters | Parameter charsSet should be final. | 13 |
| Error |
coding | HiddenField | 'charsSet' hides a field. | 13 |
| Error |
design | DesignForExtension | Class 'BruteForceTaskParam' looks like designed for extension (can be subclassed), but the method 'getPasswordLength' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceTaskParam' final or making the method 'getPasswordLength' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
| Error |
design | DesignForExtension | Class 'BruteForceTaskParam' looks like designed for extension (can be subclassed), but the method 'getPasswordTotalRangeSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceTaskParam' final or making the method 'getPasswordTotalRangeSize' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
| Error |
design | DesignForExtension | Class 'BruteForceTaskParam' looks like designed for extension (can be subclassed), but the method 'getPasswordSubRangeSize' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceTaskParam' final or making the method 'getPasswordSubRangeSize' static/final/abstract/empty, or adding allowed annotation for the method. | 30 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 30 |
| Error |
design | DesignForExtension | Class 'BruteForceTaskParam' looks like designed for extension (can be subclassed), but the method 'getChecker' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceTaskParam' final or making the method 'getChecker' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
| Error |
design | DesignForExtension | Class 'BruteForceTaskParam' looks like designed for extension (can be subclassed), but the method 'getCharsSet' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BruteForceTaskParam' final or making the method 'getCharsSet' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
edu/jiangxin/apktoolbox/file/password/recovery/category/dictionary/multithread/BigFileReader.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
| Error |
misc | FinalParameters | Parameter callback should be final. | 41 |
| Error |
coding | HiddenField | 'callback' hides a field. | 41 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 41 |
| Error |
coding | HiddenField | 'panel' hides a field. | 41 |
| Error |
design | DesignForExtension | Class 'BigFileReader' looks like designed for extension (can be subclassed), but the method 'start' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BigFileReader' final or making the method 'start' static/final/abstract/empty, or adding allowed annotation for the method. | 60 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 60 |
| Error |
misc | FinalParameters | Parameter start should be final. | 83 |
| Error |
misc | FinalParameters | Parameter size should be final. | 83 |
| Error |
design | DesignForExtension | Class 'BigFileReader' looks like designed for extension (can be subclassed), but the method 'shutdown' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BigFileReader' final or making the method 'shutdown' static/final/abstract/empty, or adding allowed annotation for the method. | 113 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 113 |
| Error |
misc | FinalParameters | Parameter bytes should be final. | 123 |
| Error |
design | FinalClass | Class StartEndPair should be declared as final. | 151 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 152 |
| Error |
design | VisibilityModifier | Variable 'start' must be private and have accessor methods. | 152 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 153 |
| Error |
design | VisibilityModifier | Variable 'end' must be private and have accessor methods. | 153 |
| Error |
coding | MagicNumber | '32' is a magic number. | 164 |
| Error |
coding | MagicNumber | '32' is a magic number. | 165 |
| Error |
misc | FinalParameters | Parameter obj should be final. | 170 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 171 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 173 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 175 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 178 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 186 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 187 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 188 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 190 |
| Error |
misc | FinalParameters | Parameter pair should be final. | 190 |
edu/jiangxin/apktoolbox/file/password/recovery/category/dictionary/multithread/CompleteCallback.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 4 |
edu/jiangxin/apktoolbox/file/password/recovery/category/dictionary/multithread/DictionaryMultiThreadProxy.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
design | FinalClass | Class DictionaryMultiThreadProxy should be declared as final. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
design | FinalClass | Class DictionaryMultiThreadProxyHolder should be declared as final. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
naming | ConstantName | Name 'instance' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 22 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 32 |
| Error |
coding | HiddenField | 'password' hides a field. | 33 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 53 |
edu/jiangxin/apktoolbox/file/password/recovery/category/dictionary/singlethread/DictionarySingleThreadProxy.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 11 |
| Error |
design | FinalClass | Class DictionarySingleThreadProxy should be declared as final. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
design | FinalClass | Class DictionarySingleThreadProxyHolder should be declared as final. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
naming | ConstantName | Name 'instance' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 23 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
misc | FinalParameters | Parameter charsetName should be final. | 33 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 33 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 55 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/BinaryOfficeChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
design | DesignForExtension | Class 'BinaryOfficeChecker' looks like designed for extension (can be subclassed), but the method 'getFileExtensions' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BinaryOfficeChecker' final or making the method 'getFileExtensions' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
| Error |
design | DesignForExtension | Class 'BinaryOfficeChecker' looks like designed for extension (can be subclassed), but the method 'getFileDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BinaryOfficeChecker' final or making the method 'getFileDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
design | DesignForExtension | Class 'BinaryOfficeChecker' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BinaryOfficeChecker' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
| Error |
design | DesignForExtension | Class 'BinaryOfficeChecker' looks like designed for extension (can be subclassed), but the method 'prepareChecker' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BinaryOfficeChecker' final or making the method 'prepareChecker' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
design | DesignForExtension | Class 'BinaryOfficeChecker' looks like designed for extension (can be subclassed), but the method 'checkPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'BinaryOfficeChecker' final or making the method 'checkPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
| Error |
misc | FinalParameters | Parameter password should be final. | 42 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/FileChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
design | VisibilityModifier | Variable 'file' must be private and have accessor methods. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
design | VisibilityModifier | Variable 'logger' must be private and have accessor methods. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
design | VisibilityModifier | Variable 'conf' must be private and have accessor methods. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
design | DesignForExtension | Class 'FileChecker' looks like designed for extension (can be subclassed), but the method 'attachFile' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FileChecker' final or making the method 'attachFile' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
misc | FinalParameters | Parameter file should be final. | 20 |
| Error |
coding | HiddenField | 'file' hides a field. | 20 |
| Error |
design | DesignForExtension | Class 'FileChecker' looks like designed for extension (can be subclassed), but the method 'prepareChecker' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FileChecker' final or making the method 'prepareChecker' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Error |
design | DesignForExtension | Class 'FileChecker' looks like designed for extension (can be subclassed), but the method 'toString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FileChecker' final or making the method 'toString' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 33 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 42 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/IChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 4 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/PdfChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
| Error |
design | DesignForExtension | Class 'PdfChecker' looks like designed for extension (can be subclassed), but the method 'getFileExtensions' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PdfChecker' final or making the method 'getFileExtensions' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
design | DesignForExtension | Class 'PdfChecker' looks like designed for extension (can be subclassed), but the method 'getFileDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PdfChecker' final or making the method 'getFileDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
| Error |
design | DesignForExtension | Class 'PdfChecker' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PdfChecker' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
design | DesignForExtension | Class 'PdfChecker' looks like designed for extension (can be subclassed), but the method 'prepareChecker' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PdfChecker' final or making the method 'prepareChecker' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
| Error |
design | DesignForExtension | Class 'PdfChecker' looks like designed for extension (can be subclassed), but the method 'checkPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PdfChecker' final or making the method 'checkPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
| Error |
misc | FinalParameters | Parameter password should be final. | 47 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/RarChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
misc | FinalParameters | Parameter password should be final. | 42 |
| Error |
misc | FinalParameters | Parameter b should be final. | 52 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/SevenZipChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 23 |
| Error |
misc | FinalParameters | Parameter file should be final. | 48 |
| Error |
misc | FinalParameters | Parameter password should be final. | 55 |
| Error |
misc | FinalParameters | Parameter sevenZFile should be final. | 92 |
| Error |
coding | MagicNumber | '1024' is a magic number. | 96 |
| Error |
blocks | EmptyBlock | Must have at least one statement. | 97 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 116 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/XmlBasedOfficeChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
design | DesignForExtension | Class 'XmlBasedOfficeChecker' looks like designed for extension (can be subclassed), but the method 'getFileExtensions' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XmlBasedOfficeChecker' final or making the method 'getFileExtensions' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
| Error |
design | DesignForExtension | Class 'XmlBasedOfficeChecker' looks like designed for extension (can be subclassed), but the method 'getFileDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XmlBasedOfficeChecker' final or making the method 'getFileDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
| Error |
design | DesignForExtension | Class 'XmlBasedOfficeChecker' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XmlBasedOfficeChecker' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
| Error |
design | DesignForExtension | Class 'XmlBasedOfficeChecker' looks like designed for extension (can be subclassed), but the method 'prepareChecker' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XmlBasedOfficeChecker' final or making the method 'prepareChecker' static/final/abstract/empty, or adding allowed annotation for the method. | 34 |
| Error |
design | DesignForExtension | Class 'XmlBasedOfficeChecker' looks like designed for extension (can be subclassed), but the method 'checkPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'XmlBasedOfficeChecker' final or making the method 'checkPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
| Error |
misc | FinalParameters | Parameter password should be final. | 40 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/ZipChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
| Error |
misc | FinalParameters | Parameter password should be final. | 39 |
| Error |
coding | MagicNumber | '4096' is a magic number. | 44 |
| Error |
blocks | EmptyBlock | Must have at least one statement. | 47 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/thirdparty/AbstractThirdPartyChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
design | VisibilityModifier | Variable 'toolPath' must be private and have accessor methods. | 14 |
| Error |
design | DesignForExtension | Class 'AbstractThirdPartyChecker' looks like designed for extension (can be subclassed), but the method 'prepareChecker' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractThirdPartyChecker' final or making the method 'prepareChecker' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
| Error |
design | DesignForExtension | Class 'AbstractThirdPartyChecker' looks like designed for extension (can be subclassed), but the method 'checkPassword' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractThirdPartyChecker' final or making the method 'checkPassword' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
| Error |
misc | FinalParameters | Parameter password should be final. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 61 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 65 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/thirdparty/ThirdParty7ZipChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | FinalParameters | Parameter password should be final. | 27 |
| Error |
misc | FinalParameters | Parameter password should be final. | 37 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/thirdparty/ThirdPartyRarChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | FinalParameters | Parameter password should be final. | 31 |
| Error |
misc | FinalParameters | Parameter password should be final. | 36 |
edu/jiangxin/apktoolbox/file/password/recovery/checker/thirdparty/ThirdPartyWinRarChecker.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'ThirdPartyWinRarChecker' looks like designed for extension (can be subclassed), but the method 'getFileExtensions' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ThirdPartyWinRarChecker' final or making the method 'getFileExtensions' static/final/abstract/empty, or adding allowed annotation for the method. | 6 |
| Error |
design | DesignForExtension | Class 'ThirdPartyWinRarChecker' looks like designed for extension (can be subclassed), but the method 'getFileDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ThirdPartyWinRarChecker' final or making the method 'getFileDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
| Error |
design | DesignForExtension | Class 'ThirdPartyWinRarChecker' looks like designed for extension (can be subclassed), but the method 'getDescription' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ThirdPartyWinRarChecker' final or making the method 'getDescription' static/final/abstract/empty, or adding allowed annotation for the method. | 16 |
| Error |
design | DesignForExtension | Class 'ThirdPartyWinRarChecker' looks like designed for extension (can be subclassed), but the method 'getToolPath' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ThirdPartyWinRarChecker' final or making the method 'getToolPath' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
| Error |
design | DesignForExtension | Class 'ThirdPartyWinRarChecker' looks like designed for extension (can be subclassed), but the method 'isFiltered' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ThirdPartyWinRarChecker' final or making the method 'isFiltered' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
misc | FinalParameters | Parameter password should be final. | 27 |
| Error |
design | DesignForExtension | Class 'ThirdPartyWinRarChecker' looks like designed for extension (can be subclassed), but the method 'getCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ThirdPartyWinRarChecker' final or making the method 'getCmd' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
misc | FinalParameters | Parameter password should be final. | 37 |
edu/jiangxin/apktoolbox/file/password/recovery/exception/UnknownException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 4 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 7 |
| Error |
misc | FinalParameters | Parameter cause should be final. | 7 |
edu/jiangxin/apktoolbox/file/password/recovery/exception/UnsupportedVersionException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 4 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 7 |
| Error |
misc | FinalParameters | Parameter cause should be final. | 7 |
edu/jiangxin/apktoolbox/file/zhconvert/ZHConverterUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 6 |
| Error |
imports | UnusedImports | Unused import - java.net.URISyntaxException. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 21 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 22 |
| Error |
misc | FinalParameters | Parameter rPath should be final. | 25 |
| Error |
misc | FinalParameters | Parameter properties should be final. | 25 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 50 |
| Error |
misc | FinalParameters | Parameter str should be final. | 50 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 50 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 52 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 55 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 56 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 68 |
| Error |
misc | FinalParameters | Parameter str should be final. | 68 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 68 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 70 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 73 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 74 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 82 |
| Error |
misc | FinalParameters | Parameter key should be final. | 87 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 87 |
| Error |
misc | FinalParameters | Parameter value should be final. | 87 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 88 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 95 |
| Error |
design | DesignForExtension | Class 'ZHConverterUtils' looks like designed for extension (can be subclassed), but the method 'getCharMap' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZHConverterUtils' final or making the method 'getCharMap' static/final/abstract/empty, or adding allowed annotation for the method. | 104 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 104 |
edu/jiangxin/apktoolbox/file/zhconvert/ZhConvertPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 11 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 42 |
| Error |
design | DesignForExtension | Class 'ZhConvertPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ZhConvertPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
| Error |
coding | MagicNumber | '10' is a magic number. | 108 |
| Error |
coding | MagicNumber | '10' is a magic number. | 111 |
| Error |
coding | MagicNumber | '10' is a magic number. | 120 |
| Error |
coding | MagicNumber | '10' is a magic number. | 120 |
| Error |
coding | MagicNumber | '10' is a magic number. | 120 |
| Error |
coding | MagicNumber | '10' is a magic number. | 120 |
| Error |
coding | MagicNumber | '18' is a magic number. | 132 |
| Error |
coding | MagicNumber | '0.7f' is a magic number. | 137 |
| Error |
misc | FinalParameters | Parameter e should be final. | 142 |
| Error |
whitespace | NoWhitespaceBefore | ',' is preceded with whitespace. | 162 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 162 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 166 |
| Error |
misc | FinalParameters | Parameter e should be final. | 176 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 180 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 181 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 182 |
| Error |
whitespace | WhitespaceAround | '}' is not followed by whitespace. | 185 |
| Error |
whitespace | WhitespaceAfter | 'else' is not followed by whitespace. | 185 |
| Error |
whitespace | WhitespaceAround | 'else' is not followed by whitespace. | 185 |
| Error |
whitespace | WhitespaceAround | 'else' is not preceded with whitespace. | 185 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 185 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 186 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 191 |
| Error |
misc | FinalParameters | Parameter fileList should be final. | 200 |
| Error |
misc | FinalParameters | Parameter converType should be final. | 200 |
| Error |
misc | FinalParameters | Parameter jTextArea should be final. | 200 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 202 |
| Error |
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 203 |
| Error |
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 203 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 206 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 209 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 209 |
| Error |
whitespace | WhitespaceAround | '}' is not followed by whitespace. | 210 |
| Error |
whitespace | WhitespaceAfter | 'else' is not followed by whitespace. | 210 |
| Error |
whitespace | WhitespaceAround | 'else' is not followed by whitespace. | 210 |
| Error |
whitespace | WhitespaceAround | 'else' is not preceded with whitespace. | 210 |
| Error |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 210 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 213 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 213 |
| Error |
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 215 |
| Error |
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 215 |
edu/jiangxin/apktoolbox/help/AboutPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 2 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 6 |
| Error |
design | DesignForExtension | Class 'AboutPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AboutPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 29 |
| Error |
coding | MagicNumber | '10' is a magic number. | 31 |
| Error |
coding | MagicNumber | '10' is a magic number. | 31 |
| Error |
coding | MagicNumber | '10' is a magic number. | 31 |
| Error |
coding | MagicNumber | '10' is a magic number. | 31 |
| Error |
coding | MagicNumber | '800' is a magic number. | 72 |
| Error |
coding | MagicNumber | '300' is a magic number. | 72 |
edu/jiangxin/apktoolbox/help/CheckUpdateActionListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 38 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 46 |
| Error |
misc | FinalParameters | Parameter component should be final. | 46 |
| Error |
design | DesignForExtension | Class 'CheckUpdateActionListener' looks like designed for extension (can be subclassed), but the method 'onChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'CheckUpdateActionListener' final or making the method 'onChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
| Error |
misc | FinalParameters | Parameter ex should be final. | 105 |
| Error |
misc | FinalParameters | Parameter latestVersion should be final. | 112 |
edu/jiangxin/apktoolbox/help/Constant.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 2 |
| Error |
design | FinalClass | Class Constant should be declared as final. | 11 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 12 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 16 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 20 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 21 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 25 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 26 |
edu/jiangxin/apktoolbox/help/settings/AlwaysOnTopPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
design | DesignForExtension | Class 'AlwaysOnTopPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AlwaysOnTopPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
| Error |
coding | MagicNumber | '15' is a magic number. | 19 |
edu/jiangxin/apktoolbox/help/settings/DependencyPathPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 6 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 7 |
| Error |
design | DesignForExtension | Class 'DependencyPathPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DependencyPathPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
| Error |
misc | FinalParameters | Parameter panel should be final. | 31 |
| Error |
misc | FinalParameters | Parameter label should be final. | 31 |
| Error |
misc | FinalParameters | Parameter website should be final. | 31 |
| Error |
misc | FinalParameters | Parameter confKey should be final. | 31 |
edu/jiangxin/apktoolbox/help/settings/LocalePanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
design | DesignForExtension | Class 'LocalePanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LocalePanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
| Error |
coding | MagicNumber | '15' is a magic number. | 34 |
| Error |
misc | FinalParameters | Parameter e should be final. | 74 |
| Error |
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 75 |
edu/jiangxin/apktoolbox/help/settings/LookAndFeelPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
design | DesignForExtension | Class 'LookAndFeelPanel' looks like designed for extension (can be subclassed), but the method 'createUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'LookAndFeelPanel' final or making the method 'createUI' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
| Error |
coding | MagicNumber | '15' is a magic number. | 41 |
| Error |
misc | FinalParameters | Parameter actionEvent should be final. | 82 |
| Error |
misc | FinalParameters | Parameter name should be final. | 100 |
edu/jiangxin/apktoolbox/help/settings/SettingsPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 6 |
| Error |
design | DesignForExtension | Class 'SettingsPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SettingsPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
edu/jiangxin/apktoolbox/main/MainFrame.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - edu.jiangxin.apktoolbox.help.*. | 19 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - edu.jiangxin.apktoolbox.reverse.*. | 25 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 41 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 43 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.event.*. | 44 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 60 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 63 |
| Error |
misc | FinalParameters | Parameter args should be final. | 63 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 100 |
| Error |
coding | MagicNumber | '5' is a magic number. | 110 |
| Error |
coding | MagicNumber | '5' is a magic number. | 110 |
| Error |
coding | MagicNumber | '5' is a magic number. | 110 |
| Error |
coding | MagicNumber | '5' is a magic number. | 110 |
| Error |
misc | FinalParameters | Parameter e should be final. | 149 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 330 |
| Error |
design | VisibilityModifier | Variable 'easyPanelClass' must be private and have accessor methods. | 330 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 332 |
| Error |
design | VisibilityModifier | Variable 'panel' must be private and have accessor methods. | 332 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 334 |
| Error |
design | VisibilityModifier | Variable 'title' must be private and have accessor methods. | 334 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 336 |
| Error |
misc | FinalParameters | Parameter easyPanelClass should be final. | 336 |
| Error |
coding | HiddenField | 'easyPanelClass' hides a field. | 336 |
| Error |
misc | FinalParameters | Parameter title should be final. | 336 |
| Error |
coding | HiddenField | 'title' hides a field. | 336 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 348 |
| Error |
whitespace | OperatorWrap | '|' should be on a new line. | 377 |
edu/jiangxin/apktoolbox/reverse/ApkSignerPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
| Error |
design | DesignForExtension | Class 'ApkSignerPanel' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ApkSignerPanel' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
| Error |
design | DesignForExtension | Class 'ApkSignerPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ApkSignerPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 42 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 85 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 100 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 115 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 130 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 157 |
| Error |
misc | FinalParameters | Parameter e should be final. | 160 |
| Error |
misc | FinalParameters | Parameter e should be final. | 171 |
edu/jiangxin/apktoolbox/reverse/ApktoolPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 12 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Error |
design | DesignForExtension | Class 'ApktoolPanel' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ApktoolPanel' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
| Error |
design | DesignForExtension | Class 'ApktoolPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ApktoolPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
| Error |
design | VisibilityModifier | Variable 'srcPanel' must be private and have accessor methods. | 44 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
| Error |
design | VisibilityModifier | Variable 'targetPanel' must be private and have accessor methods. | 46 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 48 |
| Error |
design | VisibilityModifier | Variable 'optionPanel' must be private and have accessor methods. | 48 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 50 |
| Error |
design | VisibilityModifier | Variable 'operationPanel' must be private and have accessor methods. | 50 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 99 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 101 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 103 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 105 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 107 |
| Error |
misc | FinalParameters | Parameter e should be final. | 166 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 193 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 195 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 197 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 199 |
| Error |
misc | FinalParameters | Parameter e should be final. | 253 |
| Error |
misc | FinalParameters | Parameter f should be final. | 282 |
edu/jiangxin/apktoolbox/reverse/AxmlPrinterPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 13 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 14 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
| Error |
design | DesignForExtension | Class 'AxmlPrinterPanel' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AxmlPrinterPanel' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
| Error |
design | DesignForExtension | Class 'AxmlPrinterPanel' looks like designed for extension (can be subclassed), but the method 'initUI' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AxmlPrinterPanel' final or making the method 'initUI' static/final/abstract/empty, or adding allowed annotation for the method. | 43 |
| Error |
misc | FinalParameters | Parameter e should be final. | 102 |
| Error |
misc | FinalParameters | Parameter e should be final. | 121 |
| Error |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 139 |
edu/jiangxin/apktoolbox/reverse/ChangeMenToPluginJdListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'ChangeMenToPluginJdListener' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenToPluginJdListener' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
edu/jiangxin/apktoolbox/reverse/ChangeMenuToPluginJadxListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginJadxListener' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginJadxListener' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginJadxListener' looks like designed for extension (can be subclassed), but the method 'isPluginNeedUnzip' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginJadxListener' final or making the method 'isPluginNeedUnzip' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginJadxListener' looks like designed for extension (can be subclassed), but the method 'getPluginStartupCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginJadxListener' final or making the method 'getPluginStartupCmd' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
edu/jiangxin/apktoolbox/reverse/ChangeMenuToPluginJdDuoListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginJdDuoListener' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginJdDuoListener' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 9 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginJdDuoListener' looks like designed for extension (can be subclassed), but the method 'isPluginNeedUnzip' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginJdDuoListener' final or making the method 'isPluginNeedUnzip' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginJdDuoListener' looks like designed for extension (can be subclassed), but the method 'getPluginStartupCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginJdDuoListener' final or making the method 'getPluginStartupCmd' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
edu/jiangxin/apktoolbox/reverse/ChangeMenuToPluginLuytenListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginLuytenListener' looks like designed for extension (can be subclassed), but the method 'getPluginFilename' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginLuytenListener' final or making the method 'getPluginFilename' static/final/abstract/empty, or adding allowed annotation for the method. | 11 |
edu/jiangxin/apktoolbox/swing/extend/EasyChildTabbedPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 4 |
| Error |
design | DesignForExtension | Class 'EasyChildTabbedPanel' looks like designed for extension (can be subclassed), but the method 'onTabSelected' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyChildTabbedPanel' final or making the method 'onTabSelected' static/final/abstract/empty, or adding allowed annotation for the method. | 6 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 6 |
edu/jiangxin/apktoolbox/swing/extend/EasyFrame.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 3 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
design | VisibilityModifier | Variable 'logger' must be private and have accessor methods. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
design | VisibilityModifier | Variable 'conf' must be private and have accessor methods. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
design | VisibilityModifier | Variable 'bundle' must be private and have accessor methods. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
design | VisibilityModifier | Variable 'image' must be private and have accessor methods. | 26 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
| Error |
misc | FinalParameters | Parameter e should be final. | 35 |
| Error |
misc | FinalParameters | Parameter e should be final. | 41 |
| Error |
design | DesignForExtension | Class 'EasyFrame' looks like designed for extension (can be subclassed), but the method 'refreshSizeAndLocation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyFrame' final or making the method 'refreshSizeAndLocation' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
| Error |
coding | MagicNumber | '800' is a magic number. | 58 |
| Error |
coding | MagicNumber | '100' is a magic number. | 58 |
edu/jiangxin/apktoolbox/swing/extend/EasyPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
design | VisibilityModifier | Variable 'logger' must be private and have accessor methods. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
design | VisibilityModifier | Variable 'conf' must be private and have accessor methods. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
design | VisibilityModifier | Variable 'bundle' must be private and have accessor methods. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
design | VisibilityModifier | Variable 'isInited' must be private and have accessor methods. | 27 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 28 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'isNeedPreChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'isNeedPreChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'init' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'init' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'getFrame' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'getFrame' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'checkAndGetFileContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'checkAndGetFileContent' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
| Error |
misc | FinalParameters | Parameter textField should be final. | 62 |
| Error |
misc | FinalParameters | Parameter key should be final. | 62 |
| Error |
misc | FinalParameters | Parameter msg should be final. | 62 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'checkAndGetNewFileContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'checkAndGetNewFileContent' static/final/abstract/empty, or adding allowed annotation for the method. | 79 |
| Error |
misc | FinalParameters | Parameter textField should be final. | 79 |
| Error |
misc | FinalParameters | Parameter key should be final. | 79 |
| Error |
misc | FinalParameters | Parameter msg should be final. | 79 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'checkAndGetDirContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'checkAndGetDirContent' static/final/abstract/empty, or adding allowed annotation for the method. | 97 |
| Error |
misc | FinalParameters | Parameter textField should be final. | 97 |
| Error |
misc | FinalParameters | Parameter key should be final. | 97 |
| Error |
misc | FinalParameters | Parameter msg should be final. | 97 |
| Error |
design | DesignForExtension | Class 'EasyPanel' looks like designed for extension (can be subclassed), but the method 'checkAndGetStringContent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EasyPanel' final or making the method 'checkAndGetStringContent' static/final/abstract/empty, or adding allowed annotation for the method. | 114 |
| Error |
misc | FinalParameters | Parameter textField should be final. | 114 |
| Error |
misc | FinalParameters | Parameter key should be final. | 114 |
| Error |
misc | FinalParameters | Parameter msg should be final. | 114 |
edu/jiangxin/apktoolbox/swing/extend/FileListPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 31 |
| Error |
design | DesignForExtension | Class 'FileListPanel' looks like designed for extension (can be subclassed), but the method 'getFileList' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FileListPanel' final or making the method 'getFileList' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 36 |
| Error |
coding | HiddenField | 'fileList' hides a field. | 37 |
| Error |
coding | MagicNumber | '6' is a magic number. | 83 |
| Error |
misc | FinalParameters | Parameter comp should be final. | 116 |
| Error |
misc | FinalParameters | Parameter t should be final. | 116 |
| Error |
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 119 |
| Error |
misc | FinalParameters | Parameter jComponent should be final. | 132 |
| Error |
misc | FinalParameters | Parameter dataFlavors should be final. | 132 |
| Error |
misc | FinalParameters | Parameter e should be final. | 144 |
| Error |
misc | FinalParameters | Parameter e should be final. | 158 |
| Error |
misc | FinalParameters | Parameter e should be final. | 173 |
| Error |
misc | FinalParameters | Parameter e should be final. | 183 |
| Error |
misc | FinalParameters | Parameter e should be final. | 190 |
| Error |
misc | FinalParameters | Parameter e should be final. | 202 |
edu/jiangxin/apktoolbox/swing/extend/NumberPlainDocument.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.text.*. | 3 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 5 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Error |
misc | FinalParameters | Parameter limit should be final. | 18 |
| Error |
coding | HiddenField | 'limit' hides a field. | 18 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
| Error |
design | DesignForExtension | Class 'NumberPlainDocument' looks like designed for extension (can be subclassed), but the method 'insertString' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'NumberPlainDocument' final or making the method 'insertString' static/final/abstract/empty, or adding allowed annotation for the method. | 23 |
| Error |
misc | FinalParameters | Parameter offset should be final. | 24 |
| Error |
misc | FinalParameters | Parameter str should be final. | 24 |
| Error |
misc | FinalParameters | Parameter attr should be final. | 24 |
edu/jiangxin/apktoolbox/swing/extend/autocomplete/AutoCompleteComboBox.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 3 |
| Error |
javadoc | JavadocType | Type Javadoc comment is missing @param <E> tag. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Error |
misc | FinalParameters | Parameter cm should be final. | 24 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
misc | FinalParameters | Parameter items should be final. | 29 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
| Error |
misc | FinalParameters | Parameter v should be final. | 34 |
| Error |
design | DesignForExtension | Class 'AutoCompleteComboBox' looks like designed for extension (can be subclassed), but the method 'autoComplete' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AutoCompleteComboBox' final or making the method 'autoComplete' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 44 |
| Error |
misc | FinalParameters | Parameter str should be final. | 44 |
| Error |
design | DesignForExtension | Class 'AutoCompleteComboBox' looks like designed for extension (can be subclassed), but the method 'getText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AutoCompleteComboBox' final or making the method 'getText' static/final/abstract/empty, or adding allowed annotation for the method. | 48 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 48 |
| Error |
design | DesignForExtension | Class 'AutoCompleteComboBox' looks like designed for extension (can be subclassed), but the method 'setText' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AutoCompleteComboBox' final or making the method 'setText' static/final/abstract/empty, or adding allowed annotation for the method. | 52 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 52 |
| Error |
misc | FinalParameters | Parameter text should be final. | 52 |
| Error |
design | DesignForExtension | Class 'AutoCompleteComboBox' looks like designed for extension (can be subclassed), but the method 'containsItem' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AutoCompleteComboBox' final or making the method 'containsItem' static/final/abstract/empty, or adding allowed annotation for the method. | 56 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
| Error |
misc | FinalParameters | Parameter itemString should be final. | 56 |
edu/jiangxin/apktoolbox/swing/extend/autocomplete/AutoCompleter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 5 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 17 |
| Error |
misc | FinalParameters | Parameter comboBox should be final. | 17 |
| Error |
coding | HiddenField | 'comboBox' hides a field. | 17 |
| Error |
misc | FinalParameters | Parameter e should be final. | 36 |
| Error |
misc | FinalParameters | Parameter e should be final. | 41 |
| Error |
misc | FinalParameters | Parameter e should be final. | 46 |
| Error |
misc | FinalParameters | Parameter text should be final. | 56 |
| Error |
misc | FinalParameters | Parameter text should be final. | 65 |
edu/jiangxin/apktoolbox/swing/extend/autocomplete/AutoCompleterInitException.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 6 |
| Error |
misc | FinalParameters | Parameter message should be final. | 6 |
edu/jiangxin/apktoolbox/swing/extend/autocomplete/ScrollBasicComboBoxUI.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 3 |
edu/jiangxin/apktoolbox/swing/extend/filepanel/FilePanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 40 |
| Error |
misc | FinalParameters | Parameter buttonText should be final. | 40 |
| Error |
coding | HiddenField | 'buttonText' hides a field. | 40 |
| Error |
design | DesignForExtension | Class 'FilePanel' looks like designed for extension (can be subclassed), but the method 'setCurrentDirectoryPath' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilePanel' final or making the method 'setCurrentDirectoryPath' static/final/abstract/empty, or adding allowed annotation for the method. | 47 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 47 |
| Error |
misc | FinalParameters | Parameter currentDirectoryPath should be final. | 47 |
| Error |
coding | HiddenField | 'currentDirectoryPath' hides a field. | 47 |
| Error |
design | DesignForExtension | Class 'FilePanel' looks like designed for extension (can be subclassed), but the method 'setFileReadyCallback' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilePanel' final or making the method 'setFileReadyCallback' static/final/abstract/empty, or adding allowed annotation for the method. | 51 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 51 |
| Error |
misc | FinalParameters | Parameter callback should be final. | 51 |
| Error |
coding | HiddenField | 'callback' hides a field. | 51 |
| Error |
design | DesignForExtension | Class 'FilePanel' looks like designed for extension (can be subclassed), but the method 'setFileSelectionMode' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilePanel' final or making the method 'setFileSelectionMode' static/final/abstract/empty, or adding allowed annotation for the method. | 55 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
| Error |
misc | FinalParameters | Parameter fileSelectionMode should be final. | 55 |
| Error |
coding | HiddenField | 'fileSelectionMode' hides a field. | 55 |
| Error |
design | DesignForExtension | Class 'FilePanel' looks like designed for extension (can be subclassed), but the method 'setDescriptionAndFileExtensions' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilePanel' final or making the method 'setDescriptionAndFileExtensions' static/final/abstract/empty, or adding allowed annotation for the method. | 59 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 59 |
| Error |
misc | FinalParameters | Parameter description should be final. | 59 |
| Error |
coding | HiddenField | 'description' hides a field. | 59 |
| Error |
misc | FinalParameters | Parameter extensions should be final. | 59 |
| Error |
coding | HiddenField | 'extensions' hides a field. | 59 |
| Error |
coding | MagicNumber | '600' is a magic number. | 81 |
| Error |
coding | MagicNumber | '30' is a magic number. | 81 |
| Error |
coding | MagicNumber | '1200' is a magic number. | 82 |
| Error |
coding | MagicNumber | '30' is a magic number. | 82 |
| Error |
design | DesignForExtension | Class 'FilePanel' looks like designed for extension (can be subclassed), but the method 'getFile' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'FilePanel' final or making the method 'getFile' static/final/abstract/empty, or adding allowed annotation for the method. | 93 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 93 |
| Error |
misc | FinalParameters | Parameter e should be final. | 99 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 123 |
| Error |
misc | FinalParameters | Parameter comp should be final. | 127 |
| Error |
misc | FinalParameters | Parameter t should be final. | 127 |
| Error |
whitespace | WhitespaceAround | '||' is not followed by whitespace. | 142 |
| Error |
misc | FinalParameters | Parameter jComponent should be final. | 154 |
| Error |
misc | FinalParameters | Parameter dataFlavors should be final. | 154 |
edu/jiangxin/apktoolbox/swing/extend/filepanel/IFileReadyCallback.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 6 |
edu/jiangxin/apktoolbox/swing/extend/listener/ChangeMenuListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
edu/jiangxin/apktoolbox/swing/extend/listener/ChangeMenuToPluginListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginListener' looks like designed for extension (can be subclassed), but the method 'isNeedPreChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginListener' final or making the method 'isNeedPreChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 12 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginListener' looks like designed for extension (can be subclassed), but the method 'onPreChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginListener' final or making the method 'onPreChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 17 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 18 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginListener' looks like designed for extension (can be subclassed), but the method 'onChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginListener' final or making the method 'onChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginListener' looks like designed for extension (can be subclassed), but the method 'preparePlugin' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginListener' final or making the method 'preparePlugin' static/final/abstract/empty, or adding allowed annotation for the method. | 28 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 29 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginListener' looks like designed for extension (can be subclassed), but the method 'isPluginNeedUnzip' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginListener' final or making the method 'isPluginNeedUnzip' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToPluginListener' looks like designed for extension (can be subclassed), but the method 'getPluginStartupCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToPluginListener' final or making the method 'getPluginStartupCmd' static/final/abstract/empty, or adding allowed annotation for the method. | 38 |
edu/jiangxin/apktoolbox/swing/extend/listener/ChangeMenuToUrlListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
| Error |
misc | FinalParameters | Parameter url should be final. | 22 |
| Error |
coding | HiddenField | 'url' hides a field. | 22 |
| Error |
design | DesignForExtension | Class 'ChangeMenuToUrlListener' looks like designed for extension (can be subclassed), but the method 'onChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuToUrlListener' final or making the method 'onChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
edu/jiangxin/apktoolbox/swing/extend/listener/IPreChangeMenuCallBack.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 5 |
edu/jiangxin/apktoolbox/swing/extend/listener/SelectDirectoryListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
| Error |
misc | FinalParameters | Parameter dialogTitle should be final. | 14 |
| Error |
coding | HiddenField | 'dialogTitle' hides a field. | 14 |
| Error |
misc | FinalParameters | Parameter pathTextField should be final. | 14 |
| Error |
coding | HiddenField | 'pathTextField' hides a field. | 14 |
| Error |
design | DesignForExtension | Class 'SelectDirectoryListener' looks like designed for extension (can be subclassed), but the method 'actionPerformed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SelectDirectoryListener' final or making the method 'actionPerformed' static/final/abstract/empty, or adding allowed annotation for the method. | 20 |
| Error |
misc | FinalParameters | Parameter e should be final. | 21 |
edu/jiangxin/apktoolbox/swing/extend/listener/SelectFileListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Error |
misc | FinalParameters | Parameter dialogTitle should be final. | 18 |
| Error |
coding | HiddenField | 'dialogTitle' hides a field. | 18 |
| Error |
misc | FinalParameters | Parameter pathTextField should be final. | 18 |
| Error |
coding | HiddenField | 'pathTextField' hides a field. | 18 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 24 |
| Error |
misc | FinalParameters | Parameter dialogTitle should be final. | 24 |
| Error |
coding | HiddenField | 'dialogTitle' hides a field. | 24 |
| Error |
misc | FinalParameters | Parameter pathTextField should be final. | 24 |
| Error |
coding | HiddenField | 'pathTextField' hides a field. | 24 |
| Error |
misc | FinalParameters | Parameter fileFilter should be final. | 24 |
| Error |
coding | HiddenField | 'fileFilter' hides a field. | 24 |
| Error |
design | DesignForExtension | Class 'SelectFileListener' looks like designed for extension (can be subclassed), but the method 'actionPerformed' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'SelectFileListener' final or making the method 'actionPerformed' static/final/abstract/empty, or adding allowed annotation for the method. | 31 |
| Error |
misc | FinalParameters | Parameter e should be final. | 32 |
edu/jiangxin/apktoolbox/swing/extend/plugin/ChangeMenuPreparePluginController.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
| Error |
misc | FinalParameters | Parameter pluginFilename should be final. | 38 |
| Error |
coding | HiddenField | 'pluginFilename' hides a field. | 38 |
| Error |
misc | FinalParameters | Parameter isPluginNeedUnzip should be final. | 38 |
| Error |
coding | HiddenField | 'isPluginNeedUnzip' hides a field. | 38 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 38 |
| Error |
coding | HiddenField | 'callBack' hides a field. | 38 |
| Error |
design | DesignForExtension | Class 'ChangeMenuPreparePluginController' looks like designed for extension (can be subclassed), but the method 'onPrepareStarted' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuPreparePluginController' final or making the method 'onPrepareStarted' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
design | DesignForExtension | Class 'ChangeMenuPreparePluginController' looks like designed for extension (can be subclassed), but the method 'onCheckFinished' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuPreparePluginController' final or making the method 'onCheckFinished' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
| Error |
misc | FinalParameters | Parameter result should be final. | 50 |
| Error |
design | DesignForExtension | Class 'ChangeMenuPreparePluginController' looks like designed for extension (can be subclassed), but the method 'onDownloadFinished' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuPreparePluginController' final or making the method 'onDownloadFinished' static/final/abstract/empty, or adding allowed annotation for the method. | 64 |
| Error |
misc | FinalParameters | Parameter result should be final. | 65 |
| Error |
design | DesignForExtension | Class 'ChangeMenuPreparePluginController' looks like designed for extension (can be subclassed), but the method 'onUnzipFinished' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuPreparePluginController' final or making the method 'onUnzipFinished' static/final/abstract/empty, or adding allowed annotation for the method. | 86 |
| Error |
misc | FinalParameters | Parameter result should be final. | 87 |
| Error |
design | DesignForExtension | Class 'ChangeMenuPreparePluginController' looks like designed for extension (can be subclassed), but the method 'onPrepareFinished' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ChangeMenuPreparePluginController' final or making the method 'onPrepareFinished' static/final/abstract/empty, or adding allowed annotation for the method. | 96 |
edu/jiangxin/apktoolbox/swing/extend/plugin/IPlugin.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 5 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 7 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 9 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 11 |
edu/jiangxin/apktoolbox/swing/extend/plugin/IPreparePluginCallback.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 4 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 6 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 8 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 12 |
edu/jiangxin/apktoolbox/swing/extend/plugin/PluginPanel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | DesignForExtension | Class 'PluginPanel' looks like designed for extension (can be subclassed), but the method 'isNeedPreChangeMenu' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginPanel' final or making the method 'isNeedPreChangeMenu' static/final/abstract/empty, or adding allowed annotation for the method. | 9 |
| Error |
design | DesignForExtension | Class 'PluginPanel' looks like designed for extension (can be subclassed), but the method 'preparePlugin' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginPanel' final or making the method 'preparePlugin' static/final/abstract/empty, or adding allowed annotation for the method. | 14 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 15 |
| Error |
design | DesignForExtension | Class 'PluginPanel' looks like designed for extension (can be subclassed), but the method 'isPluginNeedUnzip' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginPanel' final or making the method 'isPluginNeedUnzip' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
| Error |
design | DesignForExtension | Class 'PluginPanel' looks like designed for extension (can be subclassed), but the method 'getPluginStartupCmd' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginPanel' final or making the method 'getPluginStartupCmd' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
edu/jiangxin/apktoolbox/swing/extend/plugin/PluginUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | FinalClass | Class PluginUtils should be declared as final. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
| Error |
misc | FinalParameters | Parameter pluginFilename should be final. | 26 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 26 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
| Error |
misc | FinalParameters | Parameter pluginFilename should be final. | 38 |
| Error |
misc | FinalParameters | Parameter callBack should be final. | 38 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 55 |
| Error |
misc | FinalParameters | Parameter pluginFilename should be final. | 55 |
| Error |
misc | FinalParameters | Parameter callback should be final. | 55 |
edu/jiangxin/apktoolbox/swing/extend/plugin/ProgressBarDialog.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 5 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
design | VisibilityModifier | Variable 'progressBar' must be private and have accessor methods. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
design | VisibilityModifier | Variable 'progressLabel' must be private and have accessor methods. | 13 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 15 |
| Error |
misc | FinalParameters | Parameter title should be final. | 15 |
| Error |
coding | MagicNumber | '400' is a magic number. | 17 |
| Error |
coding | MagicNumber | '100' is a magic number. | 17 |
| Error |
coding | MagicNumber | '100' is a magic number. | 32 |
| Error |
coding | MagicNumber | '300' is a magic number. | 34 |
| Error |
coding | MagicNumber | '20' is a magic number. | 34 |
| Error |
design | DesignForExtension | Class 'ProgressBarDialog' looks like designed for extension (can be subclassed), but the method 'setValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProgressBarDialog' final or making the method 'setValue' static/final/abstract/empty, or adding allowed annotation for the method. | 46 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 46 |
| Error |
misc | FinalParameters | Parameter value should be final. | 46 |
edu/jiangxin/apktoolbox/swing/extend/plugin/runnable/AbstractRunnable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 6 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
design | VisibilityModifier | Variable 'callback' must be private and have accessor methods. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
design | VisibilityModifier | Variable 'progressBarDialog' must be private and have accessor methods. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
design | VisibilityModifier | Variable 'progress' must be private and have accessor methods. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
design | VisibilityModifier | Variable 'isCancelled' must be private and have accessor methods. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
design | VisibilityModifier | Variable 'isFinished' must be private and have accessor methods. | 13 |
| Error |
misc | FinalParameters | Parameter dialogTitle should be final. | 15 |
| Error |
misc | FinalParameters | Parameter callback should be final. | 15 |
| Error |
coding | HiddenField | 'callback' hides a field. | 15 |
| Error |
misc | FinalParameters | Parameter windowEvent should be final. | 20 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 25 |
| Error |
design | DesignForExtension | Class 'AbstractRunnable' looks like designed for extension (can be subclassed), but the method 'cancel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'AbstractRunnable' final or making the method 'cancel' static/final/abstract/empty, or adding allowed annotation for the method. | 36 |
edu/jiangxin/apktoolbox/swing/extend/plugin/runnable/DownloadRunnable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 9 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
misc | FinalParameters | Parameter url should be final. | 21 |
| Error |
coding | HiddenField | 'url' hides a field. | 21 |
| Error |
misc | FinalParameters | Parameter downloadDir should be final. | 21 |
| Error |
coding | HiddenField | 'downloadDir' hides a field. | 21 |
| Error |
misc | FinalParameters | Parameter callback should be final. | 21 |
| Error |
design | DesignForExtension | Class 'DownloadRunnable' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'DownloadRunnable' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 27 |
| Error |
coding | MagicNumber | '5000' is a magic number. | 35 |
| Error |
coding | MagicNumber | '2048' is a magic number. | 56 |
| Error |
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 62 |
| Error |
coding | MagicNumber | '100' is a magic number. | 62 |
edu/jiangxin/apktoolbox/swing/extend/plugin/runnable/UnzipRunnable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 19 |
| Error |
misc | FinalParameters | Parameter pluginFile should be final. | 19 |
| Error |
coding | HiddenField | 'pluginFile' hides a field. | 19 |
| Error |
misc | FinalParameters | Parameter callback should be final. | 19 |
| Error |
design | DesignForExtension | Class 'UnzipRunnable' looks like designed for extension (can be subclassed), but the method 'run' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'UnzipRunnable' final or making the method 'run' static/final/abstract/empty, or adding allowed annotation for the method. | 24 |
| Error |
coding | MagicNumber | '100' is a magic number. | 38 |
edu/jiangxin/apktoolbox/swing/treetable/MyAbstractTreeTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
design | VisibilityModifier | Variable 'root' must be private and have accessor methods. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
design | VisibilityModifier | Variable 'listenerList' must be private and have accessor methods. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
misc | FinalParameters | Parameter root should be final. | 17 |
| Error |
coding | HiddenField | 'root' hides a field. | 17 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'getRoot' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'getRoot' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'isLeaf' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'isLeaf' static/final/abstract/empty, or adding allowed annotation for the method. | 25 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 25 |
| Error |
misc | FinalParameters | Parameter node should be final. | 25 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
misc | FinalParameters | Parameter path should be final. | 29 |
| Error |
misc | FinalParameters | Parameter newValue should be final. | 29 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 35 |
| Error |
misc | FinalParameters | Parameter parent should be final. | 35 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'parent'. | 35 |
| Error |
misc | FinalParameters | Parameter child should be final. | 35 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'child'. | 35 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'addTreeModelListener' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'addTreeModelListener' static/final/abstract/empty, or adding allowed annotation for the method. | 39 |
| Error |
misc | FinalParameters | Parameter treeModelListener should be final. | 40 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'removeTreeModelListener' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'removeTreeModelListener' static/final/abstract/empty, or adding allowed annotation for the method. | 44 |
| Error |
misc | FinalParameters | Parameter treeModelListener should be final. | 45 |
| Error |
misc | FinalParameters | Parameter changeType should be final. | 49 |
| Error |
misc | FinalParameters | Parameter source should be final. | 49 |
| Error |
misc | FinalParameters | Parameter path should be final. | 49 |
| Error |
misc | FinalParameters | Parameter childIndices should be final. | 49 |
| Error |
misc | FinalParameters | Parameter children should be final. | 49 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'fireTreeNodesChanged' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'fireTreeNodesChanged' static/final/abstract/empty, or adding allowed annotation for the method. | 76 |
| Error |
misc | FinalParameters | Parameter source should be final. | 76 |
| Error |
misc | FinalParameters | Parameter path should be final. | 76 |
| Error |
misc | FinalParameters | Parameter childIndices should be final. | 76 |
| Error |
misc | FinalParameters | Parameter children should be final. | 76 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'fireTreeNodesInserted' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'fireTreeNodesInserted' static/final/abstract/empty, or adding allowed annotation for the method. | 80 |
| Error |
misc | FinalParameters | Parameter source should be final. | 80 |
| Error |
misc | FinalParameters | Parameter path should be final. | 80 |
| Error |
misc | FinalParameters | Parameter childIndices should be final. | 80 |
| Error |
misc | FinalParameters | Parameter children should be final. | 80 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'fireTreeNodesRemoved' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'fireTreeNodesRemoved' static/final/abstract/empty, or adding allowed annotation for the method. | 84 |
| Error |
misc | FinalParameters | Parameter source should be final. | 84 |
| Error |
misc | FinalParameters | Parameter path should be final. | 84 |
| Error |
misc | FinalParameters | Parameter childIndices should be final. | 84 |
| Error |
misc | FinalParameters | Parameter children should be final. | 84 |
| Error |
design | DesignForExtension | Class 'MyAbstractTreeTableModel' looks like designed for extension (can be subclassed), but the method 'fireTreeStructureChanged' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyAbstractTreeTableModel' final or making the method 'fireTreeStructureChanged' static/final/abstract/empty, or adding allowed annotation for the method. | 88 |
| Error |
misc | FinalParameters | Parameter source should be final. | 88 |
| Error |
misc | FinalParameters | Parameter path should be final. | 88 |
| Error |
misc | FinalParameters | Parameter childIndices should be final. | 88 |
| Error |
misc | FinalParameters | Parameter children should be final. | 88 |
edu/jiangxin/apktoolbox/swing/treetable/MyTreeTable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Error |
misc | FinalParameters | Parameter treeTableModel should be final. | 10 |
edu/jiangxin/apktoolbox/swing/treetable/MyTreeTableCellEditor.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
misc | FinalParameters | Parameter tree should be final. | 17 |
| Error |
coding | HiddenField | 'tree' hides a field. | 17 |
| Error |
misc | FinalParameters | Parameter table should be final. | 17 |
| Error |
coding | HiddenField | 'table' hides a field. | 17 |
| Error |
design | DesignForExtension | Class 'MyTreeTableCellEditor' looks like designed for extension (can be subclassed), but the method 'getTableCellEditorComponent' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableCellEditor' final or making the method 'getTableCellEditorComponent' static/final/abstract/empty, or adding allowed annotation for the method. | 22 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
| Error |
misc | FinalParameters | Parameter table should be final. | 22 |
| Error |
coding | HiddenField | 'table' hides a field. | 22 |
| Error |
misc | FinalParameters | Parameter value should be final. | 22 |
| Error |
misc | FinalParameters | Parameter isSelected should be final. | 22 |
| Error |
misc | FinalParameters | Parameter r should be final. | 22 |
| Error |
misc | FinalParameters | Parameter c should be final. | 22 |
| Error |
design | DesignForExtension | Class 'MyTreeTableCellEditor' looks like designed for extension (can be subclassed), but the method 'isCellEditable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableCellEditor' final or making the method 'isCellEditable' static/final/abstract/empty, or adding allowed annotation for the method. | 26 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 26 |
| Error |
misc | FinalParameters | Parameter e should be final. | 26 |
| Error |
design | DesignForExtension | Class 'MyTreeTableCellEditor' looks like designed for extension (can be subclassed), but the method 'getCellEditorValue' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableCellEditor' final or making the method 'getCellEditorValue' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
edu/jiangxin/apktoolbox/swing/treetable/MyTreeTableCellRenderer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | VisibilityModifier | Variable 'visibleRow' must be private and have accessor methods. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 18 |
| Error |
misc | FinalParameters | Parameter treeTable should be final. | 18 |
| Error |
coding | HiddenField | 'treeTable' hides a field. | 18 |
| Error |
misc | FinalParameters | Parameter model should be final. | 18 |
| Error |
misc | FinalParameters | Parameter rowHeight should be final. | 31 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'rowHeight'. | 31 |
| Error |
misc | FinalParameters | Parameter x should be final. | 43 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'x'. | 43 |
| Error |
misc | FinalParameters | Parameter y should be final. | 43 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'y'. | 43 |
| Error |
misc | FinalParameters | Parameter w should be final. | 43 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'w'. | 43 |
| Error |
misc | FinalParameters | Parameter h should be final. | 43 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'h'. | 43 |
| Error |
misc | FinalParameters | Parameter g should be final. | 50 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'g'. | 50 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 59 |
| Error |
misc | FinalParameters | Parameter table should be final. | 59 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'table'. | 59 |
| Error |
misc | FinalParameters | Parameter value should be final. | 59 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'value'. | 59 |
| Error |
misc | FinalParameters | Parameter isSelected should be final. | 59 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'isSelected'. | 59 |
| Error |
misc | FinalParameters | Parameter hasFocus should be final. | 59 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'hasFocus'. | 59 |
| Error |
misc | FinalParameters | Parameter row should be final. | 59 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'row'. | 59 |
| Error |
misc | FinalParameters | Parameter column should be final. | 59 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'column'. | 59 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 60 |
| Error |
blocks | NeedBraces | 'else' construct must use '{}'s. | 62 |
edu/jiangxin/apktoolbox/swing/treetable/MyTreeTableModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 12 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 19 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 27 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 35 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 44 |
| Error |
modifier | RedundantModifier | Redundant 'public' modifier. | 52 |
edu/jiangxin/apktoolbox/swing/treetable/MyTreeTableModelAdapter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | UnusedImports | Unused import - java.awt.Rectangle. | 3 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
design | VisibilityModifier | Variable 'tree' must be private and have accessor methods. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
design | VisibilityModifier | Variable 'treeTableModel' must be private and have accessor methods. | 14 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 16 |
| Error |
misc | FinalParameters | Parameter treeTableModel should be final. | 16 |
| Error |
coding | HiddenField | 'treeTableModel' hides a field. | 16 |
| Error |
misc | FinalParameters | Parameter tree should be final. | 16 |
| Error |
coding | HiddenField | 'tree' hides a field. | 16 |
| Error |
misc | FinalParameters | Parameter event should be final. | 21 |
| Error |
misc | FinalParameters | Parameter event should be final. | 25 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'getColumnCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'getColumnCount' static/final/abstract/empty, or adding allowed annotation for the method. | 33 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 33 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'getColumnName' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'getColumnName' static/final/abstract/empty, or adding allowed annotation for the method. | 37 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 37 |
| Error |
misc | FinalParameters | Parameter column should be final. | 37 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'getColumnClass' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'getColumnClass' static/final/abstract/empty, or adding allowed annotation for the method. | 41 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 41 |
| Error |
misc | FinalParameters | Parameter column should be final. | 41 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'getRowCount' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'getRowCount' static/final/abstract/empty, or adding allowed annotation for the method. | 45 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 45 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'nodeForRow' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'nodeForRow' static/final/abstract/empty, or adding allowed annotation for the method. | 49 |
| Error |
misc | FinalParameters | Parameter row should be final. | 49 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'getValueAt' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'getValueAt' static/final/abstract/empty, or adding allowed annotation for the method. | 54 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 54 |
| Error |
misc | FinalParameters | Parameter row should be final. | 54 |
| Error |
misc | FinalParameters | Parameter column should be final. | 54 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'isCellEditable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'isCellEditable' static/final/abstract/empty, or adding allowed annotation for the method. | 58 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 58 |
| Error |
misc | FinalParameters | Parameter row should be final. | 58 |
| Error |
misc | FinalParameters | Parameter column should be final. | 58 |
| Error |
design | DesignForExtension | Class 'MyTreeTableModelAdapter' looks like designed for extension (can be subclassed), but the method 'setValueAt' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableModelAdapter' final or making the method 'setValueAt' static/final/abstract/empty, or adding allowed annotation for the method. | 62 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
| Error |
misc | FinalParameters | Parameter value should be final. | 62 |
| Error |
misc | FinalParameters | Parameter row should be final. | 62 |
| Error |
misc | FinalParameters | Parameter column should be final. | 62 |
edu/jiangxin/apktoolbox/swing/treetable/MyTreeTableSelectionModel.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 10 |
| Error |
misc | FinalParameters | Parameter e should be final. | 15 |
| Error |
design | DesignForExtension | Class 'MyTreeTableSelectionModel' looks like designed for extension (can be subclassed), but the method 'getListSelectionModel' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'MyTreeTableSelectionModel' final or making the method 'getListSelectionModel' static/final/abstract/empty, or adding allowed annotation for the method. | 21 |
edu/jiangxin/apktoolbox/utils/Constants.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | 1 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 8 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 14 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 22 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 24 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
naming | ConstantName | Name 'zhSimple2zhTw' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
| Error |
naming | ConstantName | Name 'zhTw2zhSimple' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 34 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
edu/jiangxin/apktoolbox/utils/DateUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 10 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 15 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 18 |
| Error |
misc | FinalParameters | Parameter second should be final. | 18 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'second'. | 18 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 21 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 28 |
| Error |
misc | FinalParameters | Parameter millisecond should be final. | 28 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 38 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 41 |
| Error |
misc | FinalParameters | Parameter dateString should be final. | 41 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'dateString'. | 41 |
| Error |
coding | MagicNumber | '1000' is a magic number. | 45 |
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 52 |
| Error |
javadoc | JavadocMethod | @return tag should be present and have description. | 55 |
| Error |
misc | FinalParameters | Parameter dateString should be final. | 55 |
| Error |
javadoc | JavadocMethod | Expected @param tag for 'dateString'. | 55 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 66 |
edu/jiangxin/apktoolbox/utils/FileUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 21 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 23 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 51 |
| Error |
misc | FinalParameters | Parameter file should be final. | 51 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 56 |
| Error |
misc | FinalParameters | Parameter size should be final. | 56 |
| Error |
misc | FinalParameters | Parameter one_bi should be final. | 56 |
| Error |
naming | ParameterName | Name 'one_bi' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 56 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 62 |
| Error |
misc | FinalParameters | Parameter file should be final. | 62 |
edu/jiangxin/apktoolbox/utils/KeyVerify.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 18 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 19 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
misc | FinalParameters | Parameter keyStorePath should be final. | 20 |
| Error |
misc | FinalParameters | Parameter password should be final. | 20 |
| Error |
misc | FinalParameters | Parameter alias should be final. | 20 |
| Error |
misc | FinalParameters | Parameter aliasPassword should be final. | 20 |
edu/jiangxin/apktoolbox/utils/NoLogOutputStream.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
misc | FinalParameters | Parameter line should be final. | 7 |
| Error |
misc | FinalParameters | Parameter logLevel should be final. | 7 |
edu/jiangxin/apktoolbox/utils/ProcessLogOutputStream.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocStyle | First sentence should end with a period. | 7 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
design | VisibilityModifier | Variable 'logger' must be private and have accessor methods. | 11 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
| Error |
design | VisibilityModifier | Variable 'level' must be private and have accessor methods. | 12 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 14 |
| Error |
misc | FinalParameters | Parameter logger should be final. | 14 |
| Error |
coding | HiddenField | 'logger' hides a field. | 14 |
| Error |
misc | FinalParameters | Parameter level should be final. | 14 |
| Error |
coding | HiddenField | 'level' hides a field. | 14 |
| Error |
design | DesignForExtension | Class 'ProcessLogOutputStream' looks like designed for extension (can be subclassed), but the method 'processLine' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ProcessLogOutputStream' final or making the method 'processLine' static/final/abstract/empty, or adding allowed annotation for the method. | 19 |
| Error |
misc | FinalParameters | Parameter line should be final. | 20 |
| Error |
misc | FinalParameters | Parameter logLevel should be final. | 20 |
edu/jiangxin/apktoolbox/utils/SystemInfoUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
design | FinalClass | Class SystemInfoUtils should be declared as final. | 8 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 9 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 22 |
edu/jiangxin/apktoolbox/utils/Utils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.apache.commons.exec.*. | 10 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.swing.*. | 16 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.awt.*. | 17 |
| Error |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.io.*. | 18 |
| Error |
design | HideUtilityClassConstructor | Utility classes should not have a public or default constructor. | 25 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
| Error |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 26 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 34 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 38 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 92 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 110 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 123 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 151 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 152 |
| Error |
misc | FinalParameters | Parameter component should be final. | 152 |
| Error |
whitespace | WhitespaceAfter | 'while' is not followed by whitespace. | 154 |
| Error |
whitespace | WhitespaceAround | 'while' is not followed by whitespace. | 154 |
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 162 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 163 |
| Error |
misc | FinalParameters | Parameter component should be final. | 163 |
| Error |
misc | FinalParameters | Parameter title should be final. | 163 |
| Error |
whitespace | WhitespaceAfter | 'while' is not followed by whitespace. | 165 |
| Error |
whitespace | WhitespaceAround | 'while' is not followed by whitespace. | 165 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 174 |
| Error |
misc | FinalParameters | Parameter cmd should be final. | 174 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 190 |
| Error |
misc | FinalParameters | Parameter cmd should be final. | 190 |
| Error |
misc | FinalParameters | Parameter exitValue should be final. | 201 |
| Error |
misc | FinalParameters | Parameter ee should be final. | 206 |
| Error |
javadoc | MissingJavadocMethod | Missing a Javadoc comment. | 216 |
| Error |
misc | FinalParameters | Parameter file should be final. | 216 |